Edgewall Software
Modify

Opened 18 years ago

Closed 18 years ago

#4312 closed defect (fixed)

Attachment to ticket in timeline lacks title for ticket reference

Reported by: Tim Hatch <trac@…> Owned by: Christian Boos
Priority: normal Milestone: 0.11
Component: timeline Version: devel
Severity: trivial Keywords: attachment
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

For example, I see on the timeline right now <em>timeline_spelling.patch</em> attached to ticket <em>#4310</em>. I'm used to having a tooltip over things on the timeline that have a ticket reference, like for ticket changes, Ticket <em title="Ticket Title">#4310</em>....

This patch does it just for tickets by modifying the display callback. I'm not sure about the speed penalty.

  • trac/ticket/web_ui.py

     
    545545            # Attachments
    546546            if 'ticket_details' in filters:
    547547                def display(id):
    548                     return html('ticket ', html.em('#', id))
     548                    return html('ticket ', html.em('#', id, title=Ticket(self.env, id)['summary']))
    549549                att = AttachmentModule(self.env)
    550550                for event in att.get_timeline_events(req, db, 'ticket',
    551551                                                     start, stop, display):

Observed on t.e.o and reproduced on trunk.

Attachments (0)

Change History (2)

comment:1 by Christian Boos, 18 years ago

Keywords: attachment added
Milestone: 0.11
Owner: changed from Jonas Borgström to Christian Boos
Severity: normaltrivial

Well, this introduces no more overhead than if that would have been a regular comment for that ticket, so I guess it's OK.

comment:2 by Christian Boos, 18 years ago

Resolution: fixed
Status: newclosed

Added in r4391.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christian Boos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Christian Boos to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.