Image macro broken for attachment images

[Christopher Lenz]

The Image macro still generates the ?format=raw URL style instead of using the raw-attachment namespace.

Also, it would probably be nice to not break the URLs like that… the old style should still work or redirect to the new scheme.

[Christian Boos]

Ok, I'll fix that. The old-style URLs should definitely still work. Do you mean the old-style of TracLinks (with ?format=raw) is broken?

As a side-note, I've also taken good notice of r4333, I'll do that in the coming days.

[Christopher Lenz]

?format=raw (in the URL, don't know about TracLinks) returns the HTML preview page as opposed to the raw resource. It's quite likely people have external links using the ?format=raw style, so I think it'd be a bad idea to break them. A redirect would probably be the most appropriate solution for this.

[Christian Boos]

Ok, fixed in r4356.

I considered using raw-attachment/ for the Image macro and doing a redirect when having the explicit ?format=raw parameter given to TracLinks, but in both case this would have added cruft to the code.

• in the first case, would have to use something else than the convenient attachment.href helper
• in the second case, we should have added some logic to replace ?format=raw by /raw-attachment/, but still keep ?format=txt or other future parameter. Best keep the "no surprise" way, parameters explicitly given to TracLinks get propagated to the URL (see also #2168)