Opened 17 years ago
Closed 14 years ago
#4202 closed defect (fixed)
[PATCH] Images are not found on WikiStart page when the URL contains an ending slash
| Reported by: | Owned by: | Jonas Borgström | |
|---|---|---|---|
| Priority: | low | Milestone: | 0.11 |
| Component: | wiki system | Version: | 0.10.2 |
| Severity: | minor | Keywords: | image macro |
| Cc: | Branch: | ||
| Release Notes: | |||
| API Changes: | |||
| Internal Changes: | |||
Description
If users are redirected from a project listing page to /trac/wiki/ (with a slash), the image macro fails to show the images on the wiki start page (attachment does not exist).
This patch checks to make sure the second piece of the split path_info is not empty before assigning it to the id.
Attachments (1)
Change History (6)
by , 17 years ago
| Attachment: | trac-macro-diff.diff added |
|---|
comment:1 by , 17 years ago
| Milestone: | → 0.10.4 |
|---|---|
| Severity: | normal → minor |
comment:2 by , 17 years ago
Why does it being marked to 0.10.4 instead of 0.10.3? Since there's a know patch to it and it's a bugfix and a regression I think it should go to .3. Have I missed something?
comment:3 by , 17 years ago
| Milestone: | 0.10.4 → 0.11 |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
This is indeed a problem in 0.10-stable, but works now in 0.11, though I'm not sure about which changeset fixed it.
comment:4 by , 14 years ago
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
| Version: | 0.10.2 → 0.11.6 |
This bug seems to have popped back up in 0.11.6. If you need more details please contact me at aedgar (at) research att com
Thanks
comment:5 by , 14 years ago
| Resolution: | → fixed |
|---|---|
| Status: | reopened → closed |
| Version: | 0.11.6 → 0.10.2 |
I cannot reproduce this on 0.11.7, as URLs with a trailing slash are redirected to strip the slash (try http://trac.edgewall.org/demo-0.11/wiki/ which is running 0.11.7).
If you can provide a way to reproduce the issue on the demo site above, please open a new ticket and explain the steps.
Patch to image macro so images are rendered on wiki start page even with ending slash (/trac/wiki/)