Empty Milestone

[markus]

Trac 0.11dev tries to render "empty" milestones (see ​http://trac.edgewall.org/milestone).

trac/ticket/roadmap.py

@@ -27 +27 @@
 from trac.util.text import shorten_line, CRLF, to_unicode
 from trac.ticket import Milestone, Ticket, TicketSystem
 from trac.Timeline import ITimelineEventProvider
-from trac.web import IRequestHandler
+from trac.web.api import IRequestHandler, HTTPNotFound
 from trac.web.chrome import add_link, add_stylesheet, INavigationContributor
 from trac.wiki import wiki_to_html, wiki_to_oneliner, IWikiSyntaxProvider
 
@@ -358 +358 @@
         elif action == 'delete':
             return self._render_confirm(req, db, milestone)
 
-        return self._render_view(req, db, milestone)
+        if milestone.exists:
+            return self._render_view(req, db, milestone)
+        else:
+            raise HTTPNotFound('Milestone not found')
 
     # Internal methods

Creating the corresponding unit test is left as an exercise for the TracTeam. ;-)

[Christian Boos]

Mh, couldn't we do something more useful here, like displaying the "current" milestone?

This is what I do for changesets, looking for /changeset, you'll get the head.

[anonymous]

Replying to cboos:

Mh, couldn't we do something more useful here, like displaying the "current" milestone?

This is what I do for changesets, looking for /changeset, you'll get the head.

What do you mean by current milestone? In other words, what would be Trac's current milestone? 0.9.7, 0.10.1, 0.11? If we really want to avoid returing HttpNotFound, I'd rather redirect to the roadmap…

[Christian Boos]

Replying to anonymous:

Replying to cboos:

Mh, couldn't we do something more useful here, like displaying the "current" milestone?

This is what I do for changesets, looking for /changeset, you'll get the head.

What do you mean by current milestone? In other words, what would be Trac's current milestone? 0.9.7, 0.10.1, 0.11?

Good point, what I had in mind was the use the first milestone in the Roadmap list of opened milestones, but in the case of Trac itself, that would give 0.9.7, which is not really the "current" one (0.11 would be the interesting one).

If we really want to avoid returing HttpNotFound, I'd rather redirect to the roadmap…

Good suggestion. Any other opinion?

[Christopher Lenz]

Redirecting to the roadmap sounds good.

[Christian Boos]

Did so in r4042.

[Christian Boos]

Should we do the same for /ticket, and redirect to either /query or /reports?