#3968 closed defect (fixed)
TicketQueryMacro should not enforce order-id
Reported by: | Owned by: | Christian Boos | |
---|---|---|---|
Priority: | normal | Milestone: | 0.11 |
Component: | ticket system | Version: | devel |
Severity: | normal | Keywords: | |
Cc: | Branch: | ||
Release Notes: | |||
API Changes: | |||
Internal Changes: |
Description
The TicketQueryMacro uses default-order "id"
source:trunk/trac/ticket/query.py#3882#L720
kwargs.setdefault('order', 'id')
This line does not just set an default. It overrides an existent query parameter "&order≤field>".
It would be of benefit to remove the line completely, thus the original behaviour of the ticket query becomes available within the wiki (currently: order=priority).
This would lead to a more consistent design.
You can test the behaviour by adding this code to a wiki page:
testing order=type '''keyword-parameter''' [[TicketQuery(status=assigned|new|reopened, order=type, format=table )]] '''query-parameter''' [[TicketQuery(status=assigned|new|reopened&order=type, format=table)]]
context: http://dev.lazaridis.com/base/wiki/PlanTicketQueryMacro
Attachments (0)
Change History (5)
follow-up: 2 comment:1 by , 18 years ago
Milestone: | → 0.11 |
---|---|
Owner: | changed from | to
comment:2 by , 18 years ago
Replying to cboos:
Ilias, are you color-blind? Really, please take no offense, but I can hardly stand the mix of olive green and white background you have on your Trac site ;)
criticism is always welcome.
I've changed it to the value trac uses, although I'm not sure if that's better. I've not yet reached the point where I hand-over this task where it belongs too: to a graphic designer. I promise this will happen within… the next year!
follow-up: 5 comment:3 by , 18 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Fixed in r3999, thanks for the report!
Concerning the TicketQueryin general, I have a few more pending changes (datetime fixes and being able to select the columns in the output).
comment:4 by , 18 years ago
Sounds good.
I'll continue full-time with this task during the next days, and will emmit some requirements / tickets / patches which raise from personal and from a clients use-cases.
comment:5 by , 18 years ago
Replying to cboos:
Fixed in r3999, thanks for the report!
Concerning the TicketQueryin general, I have a few more pending changes (datetime fixes and being able to select the columns in the output).
please look at #4005
Ilias, are you color-blind? Really, please take no offense, but I can hardly stand the mix of olive green and white background you have on your Trac site ;)
Besides this little off-topic COSMETIC issue, I fully agree with you.