emailed ticket footers don't have url info in them.

[jon@…]

Upgraded to 0.11 (svn-head) and got an email with this as the footer… how can I fix it?

thanks!

jon

— Ticket URL: </ticket/404> Kink ≠ Kink

[Christian Boos]

Looks like you don't have the [trac] base_url configuration option set.

Before 0.11, if that was missing, the base_url was reconstructed from the current request, which meant in the end that the URL in the notification mail could eventually differ depending on the URL used to trigger the change.

The doc string for that option needs to be updated.

[anonymous]

Yup. It would be nice to have the missing documentation updated. Maybe when changes like this are made, documentation would be updated at the same time. =)

[Christian Boos]

#5530 was closed as duplicate.

See also #5064.

[ThurnerRupert]

TracDev/ReleaseNotes/0.11 contains it, the doc string is what is displayed in wiki:0.11/TracIni?

[Christian Boos]

See also attachment:ticket:5064:use_base_url_for_redirect-r6199.diff​, which contains an updated documentation for the [trac] base_url setting, making it clear that its main purpose is to be used as a reference base URL for things like the notification emails.

[Christian Boos]

… and as osimons suggested, we might revert to the old behavior of setting up automatically the env.abs_href from the req, although that will be a bit hackish.

trac/web/main.py

@@ -378 +378 @@
 
     req = Request(environ, start_response)
     resp = []
+
+    # fixup env.abs_href if `[trac] base_url` was not specified
+    if env and not env.abs_href.base:
+        env._abs_href = req.abs_href
+
     try:
         if not env and env_error:
             raise HTTPInternalError(env_error)

[Emmanuel Blot]

Replying to cboos:

… and as osimons suggested, we might revert to the old behavior of setting up automatically the env.abs_href from the req, although that will be a bit hackish.

There's probably a warning to trigger in the Trac log if the base_url is not set though: when a ticket notification is emitted from a hook script, for example, there's no request object per se.

[Christian Boos]

Exactly, forgot to mention that. But the warning is printed, though only once.

WARNING: base_url option not set in configuration, generated links may be incorrect

[Christian Boos]

Above patch committed as [6264].

That can be considered as a hack, but a useful one :-)