Edgewall Software
Modify

Opened 14 years ago

Last modified 19 months ago

#3519 new enhancement

browse source - edit feature?

Reported by: anonymous Owned by:
Priority: high Milestone: next-major-releases
Component: version control Version: 0.9.6
Severity: normal Keywords: edit attachment patches
Cc: itamarost@… Branch:
Release Notes:
API Changes:
Internal Changes:

Description (last modified by Christian Boos)

It would be great if when browsing the source tree through the subversion repository, there was a way to pull up an "Edit" box to make quick edits to files and submit them to the subversion repository. This way I can give access to WIKI users to make edits to files within the subversion repository without them needing to set up full development environments.

Attachments (0)

Change History (10)

comment:1 by Emmanuel Blot, 14 years ago

Potential duplicates / related requests: #2956, #2755

comment:2 by Matthew Good, 14 years ago

Type: defectenhancement

comment:3 by Christian Boos, 14 years ago

Milestone: 2.0
Owner: changed from Christopher Lenz to Christian Boos

Potentially useful for making small edits, like fixing typos, the inlined documentation, etc.

comment:4 by Christian Boos, 14 years ago

#5131 was closed as duplicate of this ticket.

comment:5 by Christian Boos, 11 years ago

Milestone: 2.0unscheduled

Milestone 2.0 deleted

in reply to:  3 ; comment:6 by Christian Boos, 10 years ago

Description: modified (diff)
Keywords: edit review zattachment patches added
Milestone: triagingnext-major-0.1X
Priority: normalhigh

Replying to cboos:

Potentially useful for making small edits, like fixing typos, the inlined documentation, etc.

And instead of "saving" by performing a commit, we could create a diff as an attachment to an existing ticket or to a new one (if the ticket field is left blank).

The "Review changes" page should present the diff in the usual way, but also a textarea containing the diff as plain text for copy/pasting (or should have a link to the raw diff).

That would be for the "Edit" feature, a related feature could be "Review" (a simple form of #2035), where the original text would be quoted (> ...), and the saving would create a new comment for the selected ticket (or, like in the above, a new ticket if the ticket field is left empty).

Those two features would be useful not only for source files in the repository, but also for attachments. Combined with a patch renderer that is more resilient to "fragmented" patches, it would make it easier to review patches.

comment:7 by Itamar Ostricher, 10 years ago

Cc: itamarost@… added

in reply to:  6 comment:8 by Christian Boos, 10 years ago

Replying to cboos:

Replying to cboos:

Potentially useful for making small edits, like fixing typos, the inlined documentation, etc.

And instead of "saving" by performing a commit, we could create a diff as an attachment to an existing ticket or to a new one (if the ticket field is left blank).

The "Review changes" page should present the diff in the usual way, but also a textarea containing the diff as plain text for copy/pasting (or should have a link to the raw diff).

I just noticed that something very close has been recently(?) added to GoogleCode.

a related feature could be "Review" (a simple form of #2035), where the original text would be quoted (> ...), and the saving would create a new comment for the selected ticket (or, like in the above, a new ticket if the ticket field is left empty). … (needs a) patch renderer that is more resilient to "fragmented" patches, it would make it easier to review patches.

That would be the difficult part. We should be able to deal with this kind of input:

Index: TracOnUbuntu
===================================================================
--- Version 81
+++ Version 82
@@ -12,7 +12,7 @@
 '''Note:''' It is always best practice to use the latest [wiki:WikiStart stable version] of Trac.
 
 ||= tutorial =||=  Ubuntu Version =||= Trac Version =||= Apache =||= VCS =||= Database =||
-|| [wiki:Ubuntu-11.04-Subversion] || 10.04 || 0.12 || Mod_Python || Subversion || MySQL||
+|| [wiki:Ubuntu-11.04-Subversion Ubuntu-10.04-Subversion] || 10.04 || 0.12 || Mod_Python || Subversion || MySQL||

Really?

 || [wiki:Ubuntu-10.04-Bazaar] || 10.04 || 0.12 || Mod_WSGI || Bazaar || MySQL||
 || [https://help.ubuntu.com/community/Trac ubuntu Help] || ?|| ?|| Mod_Python || ?|| SQLite||
 || [wiki:0.11/TracOnUbuntu] || 8.04 || 0.11 || Mod_Python || Subversion || SQLite||

comment:9 by Christian Boos, 10 years ago

Keywords: attachment added; review zattachment removed

See also #9248 for an use case in which it would actually be useful to modify the repository (e.g. a clone dedicated to contributions in one area, like the documentation).

We could have a generic file edit/preview/review feature, but a IBrowserWriter interface, which could implement either the creation of a patch (and optionally attaching it to a ticket or create a new ticket), or directly saving the edited content in a new changeset.

comment:10 by Ryan J Ollos, 6 years ago

Owner: Christian Boos removed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The ticket will remain with no owner.
The ticket will be disowned.
as The resolution will be set. Next status will be 'closed'.
The owner will be changed from (none) to anonymous. Next status will be 'assigned'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.