Edgewall Software
Modify

Opened 16 years ago

Closed 16 years ago

Last modified 16 years ago

#3520 closed enhancement (fixed)

ITicketChangeListener.ticket_changed should be passed the author of the change

Reported by: exarkun@… Owned by: Matthew Good
Priority: normal Milestone: 0.10
Component: general Version: devel
Severity: normal Keywords: journaling
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

It is difficult or impossible to find this information otherwise.

Attachments (0)

Change History (6)

comment:1 by Christian Boos, 16 years ago

Keywords: journaling added
Owner: changed from Jonas Borgström to Christian Boos

See also TracDev/Proposals/Journaling, which discusses the matter of making the change listener interfaces more effective.

comment:2 by Christopher Lenz, 16 years ago

Milestone: 0.10

Would be a good idea to get this change into 0.10 to avoid the API breakage in a subsequent release.

comment:3 by Christian Boos, 16 years ago

You mean that for 0.10, we should simply add the author info, like:

-    def ticket_changed(ticket, comment, old_values):
+    def ticket_changed(ticket, author, comment, old_values):

Yes, why not.

But, I think that in the long run, the API should evolve anyway, along the lines of the proposal mentioned above.

comment:4 by Christian Boos, 16 years ago

Owner: Christian Boos removed

I'll do something about this in 0.11, if in the meantime (for 0.10 or 0.10.x) someone wants to implement this, feel free.

in reply to:  3 comment:5 by Matthew Good, 16 years ago

Owner: set to Matthew Good
Status: newassigned

Replying to cboos:

You mean that for 0.10, we should simply add the author info, like:

-    def ticket_changed(ticket, comment, old_values):
+    def ticket_changed(ticket, author, comment, old_values):

Yes, why not.

For consistency with the IWikiChangeListener maybe author should go after comment:

def ticket_changed(ticket, comment, author, old_value):

I can do this to make sure it gets in for 0.10.

comment:6 by Matthew Good, 16 years ago

Resolution: fixed
Status: assignedclosed

Ok. Added in r3692.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Matthew Good.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Matthew Good to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.