ITicketChangeListener.ticket_changed should be passed the author of the change

[exarkun@…]

It is difficult or impossible to find this information otherwise.

[Christian Boos]

See also TracDev/Proposals/Journaling, which discusses the matter of making the change listener interfaces more effective.

[Christopher Lenz]

Would be a good idea to get this change into 0.10 to avoid the API breakage in a subsequent release.

[Christian Boos]

You mean that for 0.10, we should simply add the author info, like:

-    def ticket_changed(ticket, comment, old_values):
+    def ticket_changed(ticket, author, comment, old_values):

Yes, why not.

But, I think that in the long run, the API should evolve anyway, along the lines of the proposal mentioned above.

[Christian Boos]

I'll do something about this in 0.11, if in the meantime (for 0.10 or 0.10.x) someone wants to implement this, feel free.

[Matthew Good]

Replying to cboos:

You mean that for 0.10, we should simply add the author info, like:

-    def ticket_changed(ticket, comment, old_values):
+    def ticket_changed(ticket, author, comment, old_values):

Yes, why not.

For consistency with the IWikiChangeListener maybe author should go after comment:

def ticket_changed(ticket, comment, author, old_value):

I can do this to make sure it gets in for 0.10.

[Matthew Good]

Ok. Added in r3692.