Add "No Tickets" Result to TicketQuery macro

[brian]

I think the TicketQuery macro should display "No results" or "No tickets" or something to indicate the query worked, but that there are no tickets.

For instance, I have some pages the describe the modules of the program. Each page lists the open tickets for that module (yes, I know this is available elsewhere, but sometimes it is helpful to have in the wiki too) The heading says "Open Tickets" and if there aren't any, it just has whitespace under it. This hints that there are no open tickets, but it isn't concrete.

I modified query.py to write "No open tickets" so it would be clear.

This isn't the best way, because not all TicketQuery usage will be looking for open tickets. It would be nice to have a parameter of the TicketQuery macro be "message if none found". So you could write:

[[TicketQuery(status=new,"No new tickets")]]

This would list all the new tickets, or if there aren't any, it would display "No new tickets"

[brian]

I do not know the Python programming language, but I took a stab at making this work.

I'm attaching the whole query.py file.

[brian]

Modified query.py to allow param for no results message

[brian]

An attempt at making a patch

[Christian Boos]

Not for 0.10

[sid]

Or why not something even simpler (based on trunk / r4326):

trac/ticket/query.py

@@ -782 +782 @@
                 return html.DL([(html.DT(ticket_anchor(ticket)),
                                  html.DD(ticket['summary']))
                                 for ticket in tickets], class_='wiki compact')
+        else:
+            return html.P('No tickets found.')

[brian]

There might be some cases when no query results should be blank. Or the text might be specific to the query.

It seems like having a parameter just gives more flexibility and the query macro seems to be a good place to have lots of flexibility.

[anonymous]

Uh, yeah… looking at the version of ​this page on my trac site is massively confusing, because there's nothing in the list and it looks like the query isn't working. One really can't tell from that what the macro is supposed to be doing.

I've upped the priority because unless addressed, for many people I think this feature will just appear to be broken.

[Christian Boos]

Implemented in r5458. That "No results" string is returned in a span.query_no_results element, so that it's possible to tweak its presentation further (red, blink … or even display: none to match the previous behavior).