Edgewall Software
Modify

Opened 18 years ago

Closed 17 years ago

#3203 closed enhancement (duplicate)

Hide SVK revision links in repository browser

Reported by: lasi@… Owned by: Jonas Borgström
Priority: low Milestone:
Component: version control/browser Version: 0.9.5
Severity: minor Keywords: svk
Cc: lasi@…, mortonda@… Branch:
Release Notes:
API Changes:
Internal Changes:

Description

Hi

In a project using trac tool, we use svk as svn clients. In the trac browser view, we have a problem. SVK insert a comment with the local revision of the file. In the view there ara a row with de SVN correct revision and a link to the local SVK revision (incorrect) in the Last Change row.

I can't eliminate the SVK revision link in the browser.cs template. The code that generate this link is in the versioncontrol/web_ui/changeset.py file.

¿Would be too complex move the link generation to the template?

Thanks a lot.

Javi

PD: Sorry my poor english

Attachments (0)

Change History (4)

comment:1 by Christopher Lenz, 18 years ago

Summary: More MVC separationProblem with SVK links in repository browser

Please provide more details about the problem (at least don't quite understand what the problem is). Whether or not this problem could be worked around if generation of the link was done by the template is not relevant IMHO.

comment:2 by Matthew Good, 18 years ago

Keywords: integration design removed
Summary: Problem with SVK links in repository browserHide SVK revision links in repository browser
Type: defectenhancement

Since SVK uses SVN underneath, it has its own revision numbers from the local repository. By default it adds a header when pushing changes out to the central SVN server that include information on the original SVK revision(s) it was based on, like:

r9671:  matt | 2006-05-16 12:01:53 -0400

Trac recognizes r9671 as an SVN-style revision number and turns it into a link, but it corresponds to a revision on the developer's computer, not one on the server.

The link-generation can't be handled in the template because it's part of the Trac Wiki syntax, which is far too complicated to do in the template. I always use the "—verbatim" option when pushing changes to the server so that those headers aren't added, since they're pretty useless IMO. I don't really know of a good way to hide them on Trac once they're already in the commit messages.

comment:3 by mortonda@…, 17 years ago

Cc: mortonda@… added

I got hit with this too:

from http://www.maiamailguard.org/maia/changeset/1117

r1214@dhd: dgm | 2006-12-17 21:33:27 -0600 

In my case, I would be happy if I could turn off the r### wiki link and keep just ### type link.

As another workaround, I may try putting { brackets around the log message.

comment:4 by Christian Boos, 17 years ago

Resolution: duplicate
Status: newclosed

As mgood said, using --verbatim is a good workaround in this situation.

Another one is to turn off wiki formatting completely in commit log message (see TracIni#changeset-section).

See also #4778.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Jonas Borgström.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Jonas Borgström to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.