Modify ↓
Opened 19 years ago
Last modified 9 years ago
#2733 new enhancement
Push some more behaviour to the vc backend
| Reported by: | Lele Gaifax | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | next-major-releases |
| Component: | version control | Version: | 0.9.3 |
| Severity: | normal | Keywords: | cache |
| Cc: | Branch: | ||
| Release Notes: | |||
| API Changes: | |||
| Internal Changes: | |||
Description
In order to get my new TracDarcs plugin working, I had to apply this patch that
- Fixes #2731
- Adds an "hash" field to the
revisiontable - Moves the actual insertion of the cache data from the
CachedRepositoryclass to theChangesetone
Point 3 allows the backend to augment the cached data as needed, simply by overriding a Changeset method (see for example).
Of course, I could have reimplemented the whole sync() machinery in a subclass of CachedRepository, but DRY approach suggests that's not the right way.
Attachments (0)
Change History (7)
comment:1 by , 19 years ago
comment:3 by , 16 years ago
| Keywords: | cache added |
|---|---|
| Milestone: | 0.13 → 0.12 |
comment:5 by , 15 years ago
The patch is unfortunately not available anymore, so I have trouble deciding if this should still be done (possibly on multirepos). Lele, any chance of getting a current patch?
comment:6 by , 15 years ago
| Milestone: | 0.12 → next-major-0.1X |
|---|
comment:7 by , 9 years ago
| Owner: | removed |
|---|
Note:
See TracTickets
for help on using tickets.
It would help if you explained the purpose of the "hash" column since it's not actually used in the patch anywhere.
What changes are necessary in the cache? The classes in
trac.versioncontrol.apiare meant to be decoupled from the cache, so if it's necessary to extend the cache, this should be done in thecachemodule, notapi.