Edgewall Software
Modify

Opened 13 years ago

Last modified 4 years ago

#2733 new enhancement

Push some more behaviour to the vc backend

Reported by: Lele Gaifax Owned by:
Priority: normal Milestone: next-major-releases
Component: version control Version: 0.9.3
Severity: normal Keywords: cache
Cc: Branch:
Release Notes:
API Changes:

Description

In order to get my new TracDarcs plugin working, I had to apply this patch that

  1. Fixes #2731
  2. Adds an "hash" field to the revision table
  3. Moves the actual insertion of the cache data from the CachedRepository class to the Changeset one

Point 3 allows the backend to augment the cached data as needed, simply by overriding a Changeset method (see for example).

Of course, I could have reimplemented the whole sync() machinery in a subclass of CachedRepository, but DRY approach suggests that's not the right way.

Attachments (0)

Change History (7)

comment:1 by Matthew Good, 13 years ago

It would help if you explained the purpose of the "hash" column since it's not actually used in the patch anywhere.

What changes are necessary in the cache? The classes in trac.versioncontrol.api are meant to be decoupled from the cache, so if it's necessary to extend the cache, this should be done in the cache module, not api.

comment:2 by Christian Boos, 12 years ago

Milestone: 0.12
Owner: changed from Christopher Lenz to Christian Boos

comment:3 by Christian Boos, 10 years ago

Keywords: cache added
Milestone: 0.130.12

comment:4 by Christian Boos, 10 years ago

comment:5 by Remy Blank, 10 years ago

The patch is unfortunately not available anymore, so I have trouble deciding if this should still be done (possibly on multirepos). Lele, any chance of getting a current patch?

comment:6 by Christian Boos, 10 years ago

Milestone: 0.12next-major-0.1X

comment:7 by Ryan J Ollos, 4 years ago

Owner: Christian Boos removed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The ticket will remain with no owner.
The ticket will be disowned.
as The resolution will be set.
The owner will be changed from (none) to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.