[patch] Trac does not allow spaces in postgres database passwords

[jacob@…]

Trac currently doesn't allow spaces in postgres database passwords; the following patch (against r2616) fixes it:

Index: trac/db/postgres_backend.py
===================================================================
--- trac/db/postgres_backend.py (revision 2616)
+++ trac/db/postgres_backend.py (working copy)
@@ -91,7 +91,7 @@
             if user:
                 dsn.append('user=' + user)
             if password:
-                dsn.append('password=' + password)
+                dsn.append("password='%s'" % password)
             if host:
                 dsn.append('host=' + host)
             if port:

[sid]

patch attached, needs to be reviewed

[Matthew Good]

Jacob or John can you test this patch which quotes all parameters to the DSN:

trac/db/postgres_backend.py

@@ -119 +119 @@
         if 'host' in params:
             host = params['host']
         if psycopg:
-            dsn = []
-            if path:
-                dsn.append('dbname=' + path)
-            if user:
-                dsn.append('user=' + user)
-            if password:
-                dsn.append('password=' + password)
-            if host:
-                dsn.append('host=' + host)
-            if port:
-                dsn.append('port=' + str(port))
-            cnx = psycopg.connect(' '.join(dsn))
+            dsn = {'dbname': path, 'user': user, 'password': password,
+                   'host': host, 'port': port}
+            cnx = psycopg.connect(' '.join([("%s='%s'" % k,v) for k,v
+                                            in dsn.iteritems() if v]))
             cnx.set_client_encoding('UNICODE')
         else:
             # Don't use chatty, inefficient server-side cursors.

[John Hampton]

OK, so patch is mostly correct. The bigger issue is that enabling spaces also screws up the db uri parser. I'll start working on a patch for that.

[John Hampton]

Fixed in [9225]

[Christian Boos]

Meep.

Python 2.4.4 (#71, Oct 18 2006, 08:34:43) [MSC v.1310 32 bit (Intel)] on win32
>>> from itertools import combinations
Traceback (most recent call last):
  File "<stdin>", line 1, in ?
ImportError: cannot import name combinations

ActivePython 2.5.4.4 (ActiveState Software Inc.) based on
Python 2.5.4 (r254:67916, Apr 27 2009, 15:41:14) [MSC v.1310 32 bit (Intel)] on win32

>>> from itertools import combinations
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ImportError: cannot import name combinations

Plus note that itertools is riddled with memory issues, try to avoid it (ok, for the tests it's fine).

[John Hampton]

See what I get for writing tests? :)

Test fixed in [9229]