Wiki timeline URLs should contain the version

[sudonym@…]

URLs constructed on the timeline page and rss version for changes to Wiki pages only contain links to the Wiki page that was changed, not to the actual version of the Wiki page. This leads to non-unique URLs in the rss feeds which break many readers, as well as having links on the timeline to non specific Wiki page versions. This patch corrects this issue:

trac/wiki/web_ui.py

@@ -129 +129 @@
             format = req.args.get('format')
             db = self.env.get_db_cnx()
             cursor = db.cursor()
-            cursor.execute("SELECT time,name,comment,author "
+            cursor.execute("SELECT time,name,comment,author,version "
                            "FROM wiki WHERE time>=%s AND time<=%s",
                            (start, stop))
-            for t,name,comment,author in cursor:
+            for t,name,comment,author,version in cursor:
                 title = '<em>%s</em> edited by %s' % (
                         escape(name), escape(author))
                 if format == 'rss':
-                    href = self.env.abs_href.wiki(name)
+                    href = escape(self.env.abs_href.wiki(name,version=version))
                     comment = wiki_to_html(comment or '--', self.env, db,
                                            absurls=True)
                 else:
-                    href = self.env.href.wiki(name)
+                    href = escape(self.env.href.wiki(name,version=version))
                     comment = wiki_to_oneliner(comment, self.env, db,
                                                shorten=True)
                 yield 'wiki', href, title, t, author, comment

[Christopher Lenz]

(fixed description)

[anonymous]

Thanks for cleaning up the description. There doesn't appear to be an attach file link on the new ticket page so I didn't see the link till after the initial submission.

[Christian Boos]

Dupe of #239, though the note about RSS readers requiring different URLs is interesting.

[Christopher Lenz]

I do not agree that this is a duplicate.

[Christian Boos]

Right, was not the same thing as #239.

But from the TracTimeline, if one goes to a specific version, it should also be possible to quickly jump to the latest version, as well as eventually navigate between versions.

[Christian Boos]

Implemented in r4365, together with restoring the version banner (version info + comment) when viewing a specific version.