Edgewall Software
Modify

Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#2191 closed defect (fixed)

[patch] Notification mails use LF instead of CRLF

Reported by: m.kooijman@… Owned by: Christopher Lenz
Priority: high Milestone: 0.9
Component: ticket system Version: 0.9b1
Severity: normal Keywords:
Cc: m.kooijman@…, nunterberg@… Branch:
Release Notes:
API Changes:

Description

About half the newlines in notify emails are generated as LF instead of CRLF, which causes some mailservers to just remove them and screwing up formatting for the notify message and making email notification not workable. (I have observed a direct path using only exim and/or postfix to work, but when run via exim, ESMTP and fetchmail, it broke).

I have been playing around with a few fixes, some of which refused to work at first for some weird reason. Anyway, I've found two sources of LF:

  • The email template is a file with newlines. I think setting svn:eol-style = CRLF on this file should do the trick.
  • A few hardcoded '\n' in Notify.py. Replacing these with the CRLF constant fixes that.

Tested with 0.9b1, but there are no relevant changes in b2 or trunk which would fix this.

Priority set to high, since this makes email notification unusable on some systems.

Attachments (2)

notify_crlf.diff (1015 bytes ) - added by m.kooijman@… 13 years ago.
Patch for this problem, made against 0.9b1, but should apply cleanly against latest trunk
notify_crlf2.diff (576 bytes ) - added by m.kooijman@… 13 years ago.
Same file, but with two lines of debug code removed. Oops…

Download all attachments as: .zip

Change History (10)

by m.kooijman@…, 13 years ago

Attachment: notify_crlf.diff added

Patch for this problem, made against 0.9b1, but should apply cleanly against latest trunk

by m.kooijman@…, 13 years ago

Attachment: notify_crlf2.diff added

Same file, but with two lines of debug code removed. Oops…

comment:1 by anonymous, 13 years ago

Cc: m.kooijman@… added

comment:2 by m.kooijman@…, 13 years ago

To show the problem: This how I received the email message of the last change. Notice the missing newlines… (Kinda takes the poing out of the signature, doesn't it? ;-)

comment:3 by Christopher Lenz, 13 years ago

Milestone: 0.9
Owner: changed from Jonas Borgström to Christopher Lenz
Status: newassigned

Looks good.

comment:4 by Christopher Lenz, 13 years ago

Resolution: fixed
Status: assignedclosed

Applied modified patch in [2329]. Please test.

comment:5 by m.kooijman@…, 13 years ago

Works :-)

comment:6 by Norbert Unterberg <nunterberg@…>, 13 years ago

Does this also fix Ticket #1139? I can't try right now…

comment:7 by Norbert Unterberg <nunterberg@…>, 13 years ago

Cc: nunterberg@… added

comment:8 by Matthijs Kooijman <m.kooijman@…>, 13 years ago

I wouldn't know, I've never experienced #1139. Can you check later?

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christopher Lenz.
The resolution will be deleted.
to The owner will be changed from Christopher Lenz to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.