wiki linkify of commit logs doesn't handle svn+ssh:// links

[anonymous]

In our commit logs we have references to svn paths in the form ​svn+ssh://… trac converts this to a ​ssh:// url instead of ​svn+ssh:// url. trac should have support for parsing standard svn+<encapsulation>: links.

[Christian Boos]

formatter.py

@@ -137 +137 @@
                   r"(?P<inlinecode>!?\{\{\{(?P<inline>.*?)\}\}\})",
                   r"(?P<inlinecode2>!?`(?P<inline2>.*?)`)",
                   r"(?P<htmlescapeentity>!?&#\d+;)"]
-    _post_rules = [r"(?P<shref>!?((?P<sns>\w+):(?P<stgt>'[^']+'|\"[^\"]+\"|((\|(?=[^| ])|[^| ])*[^|'~_\., \)]))))",
-                   r"(?P<lhref>!?\[(?P<lns>\w+):(?P<ltgt>[^\] ]+)(?: (?P<label>.*?))?\])",
+    _post_rules = [r"(?P<shref>!?((?P<sns>[\w+]+):(?P<stgt>'[^']+'|\"[^\"]+\"|((\|(?=[^| ])|[^| ])*[^|'~_\., \)]))))",
+                   r"(?P<lhref>!?\[(?P<lns>[\w+]+):(?P<ltgt>[^\] ]+)(?: (?P<label>.*?))?\])",
                    r"(?P<macro>!?\[\[(?P<macroname>[\w/+-]+)(\]\]|\((?P<macroargs>.*?)\)\]\]))",
                    r"(?P<heading>^\s*(?P<hdepth>=+)\s.*\s(?P=hdepth)\s*$)",
                    r"(?P<list>^(?P<ldepth>\s+)(?:\*|\d+\.) )",

Just wondering if there would be any adverse side effects. Probably not.

[Christopher Lenz]

We should also allow dots in the scheme/namespace.

[Christian Boos]

Yup. Just looked up the RFC 2396:

      scheme        = alpha *( alpha | digit | "+" | "-" | "." )

The change will have for consequence that CamelCase:CamelCase will not be recognized as two WikiPageNames separated by a colon, but rather as a scheme plus some unrecognized content.

The InterWiki feature also introduces this change, so that's OK for me (in the InterWiki context, CamelCase:CamelCase would be the CamelCase page in the CamelCase wiki, e.g. ​MeatBall:CamelCase)

[Christian Boos]

Implemented the above in r2134