Adding Source Links With Spaces

[brandon@…]

Someone in the SVN repository I work on added a directory name which has a space in it. I'm unable to find a way to do a source: link to this directory in the Wiki. I've tried doing the following links:

source:project/space here source:project/space here/ source:"project/space here" source:"project space here/"

Is this just a user training issue, or maybe just something that hasn't been addressed before?

Thanks,

• Brandon

[Christian Boos]

As you can see by yourself (in the description), it works now for Trac 0.9.

The only thing that currently won't work is spaces within identifiers in the link with description form:

[source:"project/space here" Look there].

renders as: Look there.

Should I add this, or was there a reason not to have it?

formatter.py

@@ -138 +138 @@
                   r"(?P<inlinecode2>!?`(?P<inline2>.*?)`)",
                   r"(?P<htmlescapeentity>!?&#\d+;)"]
     _post_rules = [r"(?P<shref>!?((?P<sns>\w+):(?P<stgt>'[^']+'|\"[^\"]+\"|((\|(?=[^| ])|[^| ])*[^|'~_\., \)]))))",
-                   r"(?P<lhref>!?\[(?P<lns>\w+):(?P<ltgt>[^\] ]+)(?: (?P<label>.*?))?\])",
+                   r"(?P<lhref>!?\[(?P<lns>\w+):(?P<ltgt>'[^']+'|\"[^\"]+\"|[^\] ]+)(?: (?P<label>.*?))?\])",
                    r"(?P<macro>!?\[\[(?P<macroname>[\w/+-]+)(\]\]|\((?P<macroargs>.*?)\)\]\]))",
                    r"(?P<heading>^\s*(?P<hdepth>=+)\s.*\s(?P=hdepth)\s*$)",
                    r"(?P<list>^(?P<ldepth>\s+)(?:\*|\d+\.) )",
@@ -269 +269 @@
     def _lhref_formatter(self, match, fullmatch):
         ns = fullmatch.group('lns')
         target = fullmatch.group('ltgt') 
+        if target[0] in "'\"":
+            target = target[1:-1]
         label = fullmatch.group('label') or target
         return self._make_link(ns, target, match, label)

[Christian Boos]

Added the previous change in r2134.

[anonymous]

Replying to brandon@…:

Someone in the SVN repository I work on added a directory name which has a space in it. I'm unable to find a way to do a source: link to this directory in the Wiki. I've tried doing the following links:

source:project/space here source:project/space here/ source:"project/space here" source:"project space here/"

Is this just a user training issue, or maybe just something that hasn't been addressed before?

Thanks,

• Brandon

It looks like it is still (trac 1.2.3) a problem to have directories or files with spaces in their name.

[Ryan J Ollos]

Replying to anonymous:

It looks like it is still (trac 1.2.3) a problem to have directories or files with spaces in their name.

You need to quote paths containing whitespace: [source:"dir with space/file with space"]. See TracLinks#QuotingspaceinTracLinks. If you have further questions, please ask on the MailingList.