Opened 19 years ago
Closed 19 years ago
#1577 closed defect (fixed)
RSS feeds don't appear to generate correct URLS
Reported by: | Owned by: | Jonas Borgström | |
---|---|---|---|
Priority: | low | Milestone: | 0.9 |
Component: | timeline | Version: | 0.8 |
Severity: | normal | Keywords: | rss url |
Cc: | Branch: | ||
Release Notes: | |||
API Changes: | |||
Internal Changes: |
Description
Links in RSS news feed have URL such as http://192.168.0.10:8080:8080/wiki/….
Attachments (1)
Change History (6)
comment:1 by , 19 years ago
by , 19 years ago
Attachment: | 0-8-4-extra-port-in-RSS-links-patch.diff added |
---|
Patch to fix double port numbers in RSS links
comment:2 by , 19 years ago
Milestone: | 0.9 |
---|
Already fixed for the trunk, therefore milestone:0.9 is not relevant
See log:trunk/templates/report_rss.cs#1283:1298
(Note that the above log: link will not work until the next Trac upgrade)
comment:3 by , 19 years ago
Why is the milestone not relevant? If this is fixed in trunk, set the milestone back to 0.9, and resolve the ticket as fixed. Or am I missing something?
comment:4 by , 19 years ago
Yes, I think this ticket reports (and provides a fix for) a problem for the Trac 0.8x series.
I feel that it somehow belongs to a 0.8.x release. The problem of course is that we don't have yet a 0.8.5 milestone.
But who knows, maybe one day we will, and therefore by resolving this ticket as fixed we loose the possibility to integrate this patch.
What I think would be needed in this case is a kind of floating milestone:0.8.x (and of course, the same can be said for the future, with a milestone:0.9.x) which can be used to associate an issue with a given maintenance branch, without necessarily settling for a "fixed" milestone.
comment:5 by , 19 years ago
Milestone: | → 0.9 |
---|---|
Resolution: | → fixed |
Status: | new → closed |
I guess there will never be a milestone 0.8.5…
Closing this as a 0.9 fix
Btw, the log TracLinks syntax used in the comment above works currently (with 0.9), but in the future, it is advised to use "@" instead of "#" for specifying revisions, i.e.
Just had the same problem in my test environment (Windows XP Pro SP2, Apache, CGI, Python 2.3.4) with 0.8.4.
In report_rss.cs, $HTTP.Protocol already includes the port, so the additional code to include the port number was doubling it up.
Patch attached.