Edgewall Software
Modify

Opened 17 years ago

Closed 15 years ago

Last modified 15 years ago

#1563 closed defect (fixed)

Timeline gives wrong time for wiki edits

Reported by: PBruin Owned by: Christopher Lenz
Priority: high Milestone: 0.9.6
Component: timeline Version: devel
Severity: major Keywords: timeline, wiki, edit
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

I have done 5 page edits over the last hour or so. The time line shows all these edits with the same time as the very first edit. So the first page was edited at 13:56 and the last at 14:40 but all show 13:56 as the change time.

BTW, is there something to block the google adverts? The block the ticket edit box on my screen so I can not really see what I am typing, this very very anoying.

Attachments (0)

Change History (10)

comment:1 by PBruin, 17 years ago

Priority: normalhigh
Severity: normalmajor

The time displayed for wiki page updates is the time that the server was last restarted.
I rebooted my restarted my server at 13:56 and all wiki changes stayed on this time even after committing several changesets. Now I restarted the server again and have the same time as of the latest restart.

comment:2 by Emmanuel Blot, 17 years ago

I also saw some weird issues with the time management (on my own Apache2 server)

I've commited a couple of changes to SVN, then I've updated a Wiki page about these changes.

The timeline shows that I first wrote the changes in the Wiki, then committed the files, and the time reported is about 35 minutes late for the Wiki page edition (02:24 whereas I wrote it a 3:01).

I did not spent time (yet) to try to reproduce this bug.

I can ssh on the server, so I'm sure the date on the server is correct (an both the client and the server are up-to-date thanks to NTP)

comment:3 by Christopher Lenz, 17 years ago

What python version and what Trac front-end are you using?

comment:4 by PBruin, 17 years ago

mod_python and python 2.3

comment:5 by PBruin, 17 years ago

This patch fixes the problem for me. It is probably not the best of styles but it works. Is it some python incompatibility?

Index: model.py
===================================================================
--- model.py	(revision 1680)
+++ model.py	(working copy)
@@ -103,7 +103,9 @@
             db.commit()
         self.version = 0
 
-    def save(self, author, comment, remote_addr, t=time.time(), db=None):
+    def save(self, author, comment, remote_addr, t=0, db=None):
+        if t == 0:
+           t = time.time()
         if not db:
             db = self.env.get_db_cnx()
             handle_ta = True

comment:6 by Christopher Lenz, 17 years ago

Owner: changed from Jonas Borgström to Christopher Lenz
Status: newassigned

Oh wow, that's a bad mistake :-P

Thanks for tracking it down!

comment:7 by Christopher Lenz, 17 years ago

Resolution: fixed
Status: assignedclosed

Fixed in [1682].

comment:8 by Lawrence Lo <lawrielo@…>, 16 years ago

Milestone: 0.90.9.6
Resolution: fixed
Status: closedreopened

Please see trac ticket 4271. I'm using tracd and python 2.3.5. It was working but after creating a custom field in the ticket I think this problem started to occur. I have been using trac for six months and had no issues until now.

comment:9 by ThurnerRupert, 15 years ago

Resolution: fixed
Status: reopenedclosed

was reopened with hint to #4271

comment:10 by PBruin, 15 years ago

Cc: peter.bruin@… removed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christopher Lenz.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Christopher Lenz to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.