Edgewall Software
Modify ↓

Opened 20 years ago

Closed 19 years ago

Last modified 16 years ago

#1562 closed defect (fixed)

Link problem for reports with dynamic variables

Reported by: t.dettrick@… Owned by: daniel
Priority: normal Milestone: 0.9
Component: report system Version: 0.9b2
Severity: major Keywords:
Cc: trac-form@… Branch:
Release Notes:
API Changes:
Internal Changes:

Description

Links given as: 

[report:123?MYVAR=myvalue My Report]

result in all of the links on the generated report consisting of things like: 

http://...../report/123?MYVAR=myvalue/ticket/345

As of Revision 1677.

Attachments (1)

report-fix.diff​ (786 bytes ) - added by trac-form@… 19 years ago.
Dubious fix for this bug.

Download all attachments as: .zip

Change History (9)

comment:1 by t.dettrick@…, 20 years ago

It appears to do this because the link: 

[report:123?MYVAR=myvalue My Report]

generates the href: 

...../report/11%3FMYVAR%3Dmyvalue

instead of: 

...../report/11?MYVAR=myvalue

This confuses Apache into believing that the OS environment variable SCRIPT_NAME is the same as REQUEST_URI, rather than being the URL of the Trac project. Obviously the solution is to stop the GET request parameters being encoded.

comment:2 by anonymous, 19 years ago

Milestone: → 0.9
Version: devel → 0.9b2

comment:3 by anonymous, 19 years ago

This worked in 0.8.x

by trac-form@…, 19 years ago

Attachment: report-fix.diff​ added

Dubious fix for this bug.

comment:4 by trac-form@…, 19 years ago

I'm not sure whether this patch is correctly implemented, but it works: eg. ​http://trac-hacks.swapoff.org/wiki/TocMacro

comment:5 by anonymous, 19 years ago

Cc: trac-form@… added

comment:6 by Christopher Lenz, 19 years ago

Resolution: → fixed
Status: new → closed

Applied patch in [2322]. Well, except for the part that removed the report shorthand syntax ;-)

comment:7 by www.ticketpoint.de, 16 years ago

There are new patches? I badly need a patch! Plz let me know. Thx

comment:8 by ebray, 16 years ago

Hmm…does BadContent also apply to usernames?

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain daniel.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from daniel to the specified user.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.