#1397 closed defect (fixed)
remove horizontal scroll bars on code blocks
Reported by: | ludde | Owned by: | Matthew Good |
---|---|---|---|
Priority: | normal | Milestone: | |
Component: | general | Version: | devel |
Severity: | normal | Keywords: | |
Cc: | Branch: | ||
Release Notes: | |||
API Changes: | |||
Internal Changes: |
Description
Don't display diffs in a scrollable textbox (or IFRAME or whatever it is).
For large diffs, the horizontal scrollbar is not visible, so you need to scroll down to the very end of the document to be able to scroll to the right.
A better solution is to put the diff in-line in the page and make use of the browser's horizontal scrollbar.
Attachments (1)
Change History (8)
comment:1 by , 20 years ago
Resolution: | → wontfix |
---|---|
Status: | new → closed |
comment:2 by , 20 years ago
Resolution: | wontfix |
---|---|
Status: | closed → reopened |
Maybe a different solution should be investigated then. It's doesn't really follow any usability guidelines to force a user to scroll down to the end of a page before the horizontal scrollbar is visible.
This is imho a major interface flaw that needs to be rectified.
comment:3 by , 20 years ago
Summary: | Don't display diffs in a textbox → remove horizontal scroll bars on code blocks |
---|
After discussion with ludde on the IrcChannel, this is generally a problem with file displays for either the repository browser and attachments. Embedded blocks should generally be ok as they are.
For the file display, we could handle it similarly to the display in the changeset view. Annotate the files with line numbers to the left and allow the text to line-wrap in order to prevent the need for horizontal scrolling.
comment:4 by , 20 years ago
Owner: | changed from | to
---|---|
Status: | reopened → new |
comment:5 by , 20 years ago
Status: | new → assigned |
---|
by , 20 years ago
Attachment: | mimeview_lined.patch added |
---|
Add support to default mimeviewer to display text in table with line numbers
comment:6 by , 20 years ago
I've attached a partial patch for supporting the line numbers in the default mimeviewer. I will try to add support for at least the Silvercity mimeviewer before checking this in.
comment:7 by , 20 years ago
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
The scrollable blocks are just <div> or <pre> blocks with the CSS style rule
overflow: auto
, which tells the browser to add scroll bars to the block if the content exceeds the block's width.These rules were added to prevent the content of a code block from spilling out into the surrounding content which looked sloppy. If you prefer the content to spill out of the block see TracInterfaceCustomization for overriding the CSS rules.