Edgewall Software
Modify ↓

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#13241 closed defect (fixed)

Inf and NaN should be rejected in auto preview timeout of prefs/userinterface

Reported by: Jun Omae Owned by: Ryan J Ollos
Priority: normal Milestone: 1.4.1
Component: general Version: 1.4
Severity: trivial Keywords:
Cc: Branch:
Release Notes:

Reject inf and nan for auto preview timeout user preference.

API Changes:
Internal Changes:

Description


Attachments (0)

Change History (5)

comment:1 by Ryan J Ollos, 4 years ago

Milestone: next-stable-1.4.x → 1.4.2
Owner: set to Ryan J Ollos
Status: new → assigned

comment:2 by Ryan J Ollos, 4 years ago

Milestone: 1.4.2 → 1.4.1

Proposed changes in [8613721e1/rjollos.git].

comment:3 by Jun Omae, 4 years ago

Looks good to me but we could use math.isinf() rather than float('inf'). 

$ python2.6
Python 2.6.9 (default, Jul 29 2017, 12:47:14)
[GCC 5.4.0 20160609] on linux4
Type "help", "copyright", "credits" or "license" for more information.
>>> import math
>>> for val in ('nan', 'inf', '+inf', '-inf'):
...   fval = float(val)
...   val, fval, math.isinf(fval), math.isnan(fval)
...
('nan', nan, False, True)
('inf', inf, True, False)
('+inf', inf, True, False)
('-inf', -inf, True, False)

comment:4 by Ryan J Ollos, 4 years ago

Release Notes: modified (diff)
Resolution: → fixed
Status: assigned → closed

Thanks, I added that change and committed in r17240, merged in r17241.

comment:5 by Ryan J Ollos, 4 years ago

Release Notes: modified (diff)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Ryan J Ollos to the specified user.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.