UndefinedError: the inline if-expression on line 109 in 'theme.html' evaluated to false and no else section was defined.

[Ryan J Ollos]

Tests pass with Jinja2 2.10.3, but ​2.11 released on 27 Jan 2020 has the following failure:

SKIP_FUNCTIONAL_TESTS=1 python  -m unittest -f -c trac.test.test_suite
..............................E
======================================================================
ERROR: test_preview_valid_xhtml (trac.tests.attachment.AttachmentModuleTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "trac/tests/attachment.py", line 610, in test_preview_valid_xhtml
    result = render(attachment)
  File "trac/tests/attachment.py", line 605, in render
    {'fragment': True})
  File "trac/web/chrome.py", line 1441, in render_template
    fragment, iterable, method)
  File "trac/web/chrome.py", line 1526, in _render_jinja_template
    s = self.render_template_string(template, data, text)
  File "trac/web/chrome.py", line 1675, in render_template_string
    string = template.render(data)
  File "/Users/rjollos/.pyenv/versions/trac-2.7.15/lib/python2.7/site-packages/jinja2/environment.py", line 1090, in render
    self.environment.handle_exception()
  File "/Users/rjollos/.pyenv/versions/trac-2.7.15/lib/python2.7/site-packages/jinja2/environment.py", line 832, in handle_exception
    reraise(*rewrite_traceback_stack(source=source))
  File "trac/templates/attachment.html", line 14, in top-level template code
    # set parent = attachments.parent if attachments else attachment.resource.parent
  File "trac/templates/layout.html", line 12, in top-level template code
    # import "macros.html" as jmacros with context
  File "trac/templates/theme.html", line 22, in top-level template code
    # block body
  File "trac/templates/theme.html", line 109, in block "body"
    # include resourcepath_template if resourcepath_template ignore missing
  File "/Users/rjollos/.pyenv/versions/trac-2.7.15/lib/python2.7/site-packages/jinja2/loaders.py", line 179, in get_source
    pieces = split_template_path(template)
  File "/Users/rjollos/.pyenv/versions/trac-2.7.15/lib/python2.7/site-packages/jinja2/loaders.py", line 28, in split_template_path
    for piece in template.split("/"):
UndefinedError: the inline if-expression on line 109 in 'theme.html' evaluated to false and no else section was defined.

----------------------------------------------------------------------
Ran 31 tests in 0.466s

FAILED (errors=1)
make: *** [unit-test] Error 1

[Ryan J Ollos]

Removing the inline if for # include statements fixes the issue ([4542edb57/rjollos.git]):

trac/templates/theme.html

@@ -106 +106 @@
          'uisymbols': req.session.get('ui.use_symbols'),
          'uinohelp': req.session.get('ui.hide_help'),
          }}|htmlattr}>
-      # include resourcepath_template if resourcepath_template ignore missing
+      # if resource_template:
+      #   include resourcepath_template ignore missing
+      # endif
       <div id="ctxtnav" class="nav">
         <h2>${_("Context Navigation")}</h2>
         # if chrome.ctxtnav:

trac/ticket/templates/milestone_view.html

@@ -57 +57 @@
           ${_("No date set")}
           # endif
           </p>
-        # include 'progress_bar.html' if stats.count ignore missing
+        # if stats.count:
+        #   include 'progress_bar.html' ignore missing
+        # endif
       </div>
 
       # if available_groups and stats.count:
@@ -81 +83 @@
             </script>
           </legend>
           # with summary = _('Shows the milestone completion status grouped by %(grouped_by)s', grouped_by=grouped_by)
-          #   include 'progress_bar_grouped.html' if groups ignore missing
+          #   if groups:
+          #     include 'progress_bar_grouped.html' ignore missing
+          #   endif
           # endwith
         </fieldset>
       </form>

trac/ticket/templates/query.html

@@ -335 +335 @@
       </form>
 
       # include 'query_results.html'
-      # include 'batch_modify.html' if tickets and batch_modify ignore missing
+      # if tickets:
+      #   include 'batch_modify.html' ignore missing
+      # endif
 
       <div id="trac-report-buttons" class="buttons">
         # set edit = report_resource and 'REPORT_MODIFY' in perm(report_resource)

trac/ticket/templates/roadmap.html

@@ -95 +95 @@
             #   set stats = mstats.stats
             #   set interval_hrefs = mstats.interval_hrefs
             #   set stats_href = mstats.stats_href
-            #   include 'progress_bar.html' if stats.count ignore missing
+            #   if stats.count:
+            #     include 'progress_bar.html' ignore missing
+            #   endif
             # endwith
           </div>

[Jun Omae]

That changes look good to me.

[Ryan J Ollos]

Thanks, committed in [17236:17237].

[Ryan J Ollos]

See #13248 for regression introduced by r17236.

[Ryan J Ollos]

Edited TracDev/PortingFromGenshiToJinja@49.

I haven't found a way to write an inline conditional that uses ignore missing after Jinja2 2.11. I made the same comment ​here as well.

[Jun Omae]

I noticed the include statement with inline-if still exists in query_results.html file. Fixed in [17802] and merged in [17803].