Log TracLinks not enabled for AuthzSourcePolicy

[Ryan J Ollos]

The log TracLinks are disabled with the following AuthzSourcePolicy (reported in ​th:comment:2:ticket:13598:

[/]
* = r
@admins = rw

The following investigation was copied from ​th:comment:3:ticket:13598:

• browser:trunk/trac/versioncontrol/svn_authz.py@17026:124,127,138-139#L121​
  • That plugin handles resource realms None and 'source'
• browser:trunk/trac/versioncontrol/web_ui/log.py@17026:359-360,364,400,416#L358​
  • log: links use repos.resource
• browser:trunk/trac/versioncontrol/api.py@17026:839,848,851-852#L839​
  • repos.resource has realm RepositoryManager.repository_realm
• browser:trunk/trac/versioncontrol/api.py@17026:328#L320​
  • RepositoryManager.repository_realm is 'repository' (not None or 'source')

[anonymous]

Could be related to #11707.

[Jun Omae]

It seems that the issue is introduced in #11972. The AuthzSourcePolicy doesn't handle repository realm, source:/tags/trac-1.2.5/trac/versioncontrol/svn_authz.py@:140-147#L113​.

[Jun Omae]

Proposed changes in [529bd8819/jomae.git].

Investigating, check_permission() expects source realm with path of the resource for LOG_VIEW action, e.g. source:/tags/trac-1.2.5/trac/versioncontrol/svn_authz.py@:146#L113​. However, repository realm is passed in [14497] (#11972).

[Ryan J Ollos]

Changes look good to me.

[Jun Omae]

Thanks for the review. I push the changes soon.

[Jun Omae]

Committed in [17171] and merged in [17172-17174].