Opened 5 years ago
Closed 5 years ago
#13202 closed defect (fixed)
Log TracLinks not enabled for AuthzSourcePolicy
| Reported by: | Ryan J Ollos | Owned by: | Jun Omae |
|---|---|---|---|
| Priority: | normal | Milestone: | 1.0.19 |
| Component: | version control | Version: | |
| Severity: | normal | Keywords: | AuthzSourcePolicy |
| Cc: | Branch: | ||
| Release Notes: |
Fixed |
||
| API Changes: | |||
| Internal Changes: | |||
Description
The log TracLinks are disabled with the following AuthzSourcePolicy (reported in th:comment:2:ticket:13598:
[/] * = r @admins = rw
The following investigation was copied from th:comment:3:ticket:13598:
- browser:trunk/trac/versioncontrol/svn_authz.py@17026:124,127,138-139#L121
- That plugin handles resource realms
Noneand'source'
- That plugin handles resource realms
- browser:trunk/trac/versioncontrol/web_ui/log.py@17026:359-360,364,400,416#L358
log:links userepos.resource
- browser:trunk/trac/versioncontrol/api.py@17026:839,848,851-852#L839
repos.resourcehas realmRepositoryManager.repository_realm
- browser:trunk/trac/versioncontrol/api.py@17026:328#L320
RepositoryManager.repository_realmis'repository'(notNoneor'source')
Attachments (0)
Change History (7)
comment:1 by , 5 years ago
comment:2 by , 5 years ago
It seems that the issue is introduced in #11972. The AuthzSourcePolicy doesn't handle repository realm, source:/tags/trac-1.2.5/trac/versioncontrol/svn_authz.py@:140-147#L113.
comment:3 by , 5 years ago
Proposed changes in [529bd8819/jomae.git].
Investigating, check_permission() expects source realm with path of the resource for LOG_VIEW action, e.g. source:/tags/trac-1.2.5/trac/versioncontrol/svn_authz.py@:146#L113. However, repository realm is passed in [14497] (#11972).
comment:4 by , 5 years ago
| Milestone: | 1.0.20 → 1.0.19 |
|---|
comment:6 by , 5 years ago
| Owner: | set to |
|---|---|
| Status: | new → assigned |
Thanks for the review. I push the changes soon.
comment:7 by , 5 years ago
| Release Notes: | modified (diff) |
|---|---|
| Resolution: | → fixed |
| Status: | assigned → closed |
Committed in [17171] and merged in [17172-17174].
Could be related to #11707.