Module and other classes should have a realm attribute

[Ryan J Ollos]

This is a follow-on to #11609 in which the realm attribute was added to Model objects. I propose to add a realm attribute to other classes, including those implementing IRequestHandler (i.e. the "Module" classes), with the realm being assigned from the class attribute defined in the class implementing IResourceManager.

This should help avoid regressions like the one mentioned in comment:12:ticket:11697.

[Ryan J Ollos]

This gets a bit confusing, because while query is not a realm on which permission checks are done, it is passed as an argument to web_context for the resource or realm parameter:

• trunk/trac/ticket/query.py@13055:1077#L1052​
• trunk/trac/ticket/query.py@13055:1165#L1164​

The basic idea I had for the changes here can be found in log:rjollos.git:t11707, but more investigation needs to be done. Fix for regression in [13055#file1] included in [a6a1b8a0/rjollos.git#file2], but I'll push a fix to the trunk now.

[Christian Boos]

I think you're right that 'query' can't be considered to be a realm. However, what if one wants to restrict access to the query module? In this case, it could be handled as an "action" on the 'ticket' realm ('query' in perm('ticket') in idealized Trac API ;-) ).

[Ryan J Ollos]

Proposed changes in log:rjollos.git:t11707.1.

[Ryan J Ollos]

Committed to trunk in [13405].