Clone button is missing if the description is empty

[Ryan J Ollos]

We could change the jQuery selector to also match the br element​.

Proposed fix:

tracopt/ticket/htdocs/ticketclone.coffee

@@ -85 +85 @@
     _("Cloned from #%(id)s:\n%(description)s",
       id: old_values.id,
       description: quoteText(old_values.description))
-  $('#ticket .description .searchable').before(clone)
+  $("#ticket .description").children(".searchable, br").before(clone)
   # clone from comment
   if old_values? and changes?
     addCloneFromComments (c for c in changes when c.cnum? and

[Ryan J Ollos]

Committed to trunk in r16766.

[Ryan J Ollos]

CoffeeScript 2 ​outputs ​line-comments: r16765.

[Ryan J Ollos]

There are some missing messages following r16765:

trac/locale/messages-js.pot

@@ -8 +8 @@
 msgstr ""
 "Project-Id-Version: Trac 1.3.4\n"
 "Report-Msgid-Bugs-To: trac-dev@googlegroups.com\n"
-"POT-Creation-Date: 2018-07-19 16:31-0700\n"
+"POT-Creation-Date: 2018-07-29 11:30-0700\n"
 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
 "Language-Team: LANGUAGE <LL@li.org>\n"
@@ -17 +17 @@
 "Content-Transfer-Encoding: 8bit\n"
 "Generated-By: Babel 2.6.0\n"
 
-#: tracopt/ticket/htdocs/ticketclone.js:22
-msgid "Clone"
-msgstr ""
-
-#: tracopt/ticket/htdocs/ticketclone.js:34
+#: tracopt/ticket/htdocs/ticketclone.js:61
 msgid "Create a new ticket from this comment"
 msgstr ""
 
-#: tracopt/ticket/htdocs/ticketclone.js:41
+#: tracopt/ticket/htdocs/ticketclone.js:70
 #, python-format
 msgid "(part of #%(ticketid)s) %(summary)s"
 msgstr ""
 
-#: tracopt/ticket/htdocs/ticketclone.js:47
+#: tracopt/ticket/htdocs/ticketclone.js:76
 #, python-format
 msgid ""
 "Copied from [%(source)s]:\n"
 "%(description)s"
 msgstr ""
 
-#: tracopt/ticket/htdocs/ticketclone.js:59
+#: tracopt/ticket/htdocs/ticketclone.js:89
 msgid "Create a copy of this ticket"
 msgstr ""
 
-#: tracopt/ticket/htdocs/ticketclone.js:60
+#: tracopt/ticket/htdocs/ticketclone.js:90
 #, python-format
 msgid "%(summary)s (cloned)"
 msgstr ""
 
-#: tracopt/ticket/htdocs/ticketclone.js:65
+#: tracopt/ticket/htdocs/ticketclone.js:95
 #, python-format
 msgid ""
 "Cloned from #%(id)s:\n"
 "%(description)s"
 msgstr ""
 
-#: tracopt/ticket/htdocs/ticketdeleter.js:16
-#: tracopt/ticket/htdocs/ticketdeleter.js:22
-msgid "Delete"
-msgstr ""
-
-#: tracopt/ticket/htdocs/ticketdeleter.js:16
-msgid "Delete ticket"
-msgstr ""
-
-#: tracopt/ticket/htdocs/ticketdeleter.js:22
-#, python-format
-msgid "Delete comment %(num)s"
-msgstr ""
-
 #: trac/admin/templates/admin_perms.html:10
 msgid "Toggle all"
 msgstr ""

Looks like it might be associated with ​template literals.

[Ryan J Ollos]

Replying to Ryan J Ollos:

Looks like it might be associated with ​template literals.

There's an open issue for supporting template literals: ​https://github.com/python-babel/babel/issues/329

[Ryan J Ollos]

Reverting to ​coffeescript 1.12.7 resolves the issue. That's the only workaround that I know of.

[Jun Omae]

According to ​browser compatibility of template literals, Internet Explorer 11 doesn't support the template literals. I don't think we should use template literals. … Or, we have dropped support of IE 11 for trunk?

[Ryan J Ollos]

Replying to Jun Omae:

Or, we have dropped support of IE 11 for trunk?

I don't know that we've discussed or made any decision.

I don't care whether we use template literals or not, the issue is that CoffeeScript chooses to use them. Unless a configuration option for CoffeeScript can be found that avoids using them, we will need to continue using Coffee script 1.x to avoid template literals.

[Ryan J Ollos]

If we stick with CoffeeScript 1.x, maybe we could parse the version in the Makefile and throw an error if the major version is not 1:

$ coffee -version
CoffeeScript version 1.12.7

[Ryan J Ollos]

In r16790, committed update of compiled CoffeeScript.

Proposed update to Makefile:

Makefile

@@ -365 +365 @@
        $(PYTHON) contrib/jinjachecker.py $(jinjaopts) $(templates)
 
 coffeescripts ?= $(shell find trac tracopt -name \*.coffee)
-coffee_version ?= $(shell coffee -v | sed -E s"|CoffeeScript version ([0-9]+)\.[0-9]+\.[0-9]+|\1|")
+coffee_version ?= $(shell coffee -v 2> /dev/null | sed -E s"|CoffeeScript version ([0-9]+)\.[0-9]+\.[0-9]+|\1|")
 
 coffee:
 ifneq "$(coffee_version)" "1"

Tested with:

• Ubuntu 16.04.1 LTS
• OSX 10.13.6

[Jun Omae]

Looks good to me.

[Ryan J Ollos]

Thanks for review. Committed to trunk in r16794.