Request.send_error shouldn't load and render the error template
|Reported by:||Ryan J Ollos||Owned by:||Ryan J Ollos|
Moved error template rendering from
Description (last modified by )
For a normal request the work of rendering a template is done in
trac.web.main. I propose having a
_send_error method in
trac.web.main that does the work of loading and rendering the error template, and have
Request.send_error behave more like
Request.send_error has rendered the template since it was added in r2957. At that time, the
Request.display method (appears to be similar to
Request.send) would also render the HDF template.
Request.send was added in r3832 and
Request.display was removed in r10405 (when ClearSilver support was removed).
Similar to the changes in r14604, there is some nesting of exception handlers in
trac.web.main that makes the code difficult to follow. There will be some proposed changes to attempt to clean up the logic.
Change History (25)
comment:3 by , 5 years ago
|Milestone:||next-major-releases → 1.3.3|
|Status:||new → assigned|
comment:10 by , 5 years ago
|API Changes:||modified (diff)|
|Status:||assigned → closed|