Edgewall Software
Modify ↓

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#13041 closed defect (fixed)

Preferences child panels use wrong provider

Reported by: Peter Suter Owned by: Ryan J Ollos
Priority: normal Milestone: 1.2.3
Component: general Version:
Severity: normal Keywords: preferences
Cc: Branch:
Release Notes:

Fixed incorrect rendering of child preference panels.

API Changes:
Internal Changes:

Description

I think preference page child panels (#11853) are broken. (Possibly since [14097]?) 

diff -r f44f904f5245 trac/prefs/web_ui.py
--- a/trac/prefs/web_ui.py	Sat Jun 09 00:11:51 2018 +0000
+++ b/trac/prefs/web_ui.py	Mon Jun 11 19:57:55 2018 +0200
@@ -96,6 +96,7 @@
         children = []
         if child_panels.get(panel_id):
             for name, label in child_panels[panel_id]:
+                provider = providers[name]
                 resp = provider.render_preference_panel(req, name)
                 ctemplate, cdata = resp[:2]
                 cdata.update(session_data)

Without this some random provider from a previous loop is used.

Attachments (0)

Change History (3)

comment:1 by Ryan J Ollos, 6 years ago

Milestone: → 1.2.3
Owner: set to Ryan J Ollos
Release Notes: modified (diff)
Status: new → assigned

Thanks for noticing. I'll add a test along with the fix.

comment:2 by Ryan J Ollos, 6 years ago

Resolution: → fixed
Status: assigned → closed

Committed to 1.2-stable in r16642,r16644 merged to trunk in r16643.

Last edited 6 years ago by Ryan J Ollos (previous) (diff)

comment:3 by Peter Suter, 6 years ago

Nice, thanks!

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Ryan J Ollos to the specified user.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.