Edgewall Software
Modify ↓

Opened 7 years ago

Closed 7 years ago

Last modified 5 years ago

#12937 closed enhancement (fixed)

Revise sample-plugins/workflow

Reported by: Ryan J Ollos Owned by: Ryan J Ollos
Priority: normal Milestone: 1.3.3
Component: general Version:
Severity: normal Keywords:
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Improved coding style of sample-plugins/workflow.

Description (last modified by Ryan J Ollos)

Several of the workflow sample-plugins​ can be improved for coding style, so they serve as better examples of how to write plugins against the latest Trac codebase.

Attachments (0)

Change History (7)

comment:1 by Ryan J Ollos, 7 years ago

Description: modified (diff)

Minor changes in r16373, r16375. I'm surprised the sample plugin is used in a functional test case. I'll try to replace the RegressionTestTicket6048 functional test case with a unit test (r6021/#6048).

I'll post additional changes for review.

Last edited 7 years ago by Ryan J Ollos (previous) (diff)

comment:2 by Ryan J Ollos, 7 years ago

Revised [6016:6017] regression test case in r16391.

Last edited 7 years ago by Ryan J Ollos (previous) (diff)

comment:3 by Ryan J Ollos, 7 years ago

Description: modified (diff)

comment:4 by Ryan J Ollos, 7 years ago

Release Notes: modified (diff)

comment:5 by Ryan J Ollos, 7 years ago

Resolution: → fixed
Status: assigned → closed

Changes committed in r16521. Created #13013.

comment:6 by Ryan J Ollos, 6 years ago

Remove unused import in r16667.

comment:7 by Ryan J Ollos, 5 years ago

Internal Changes: modified (diff)
Release Notes: modified (diff)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Ryan J Ollos to the specified user.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.