Edgewall Software
Modify ↓

Opened 17 years ago

Closed 17 years ago

Last modified 7 years ago

#6048 closed defect (fixed)

apply_action_side_effects not called unless changes made to a ticket.

Reported by: kirean@… Owned by: Eli Carter
Priority: normal Milestone: 0.11
Component: ticket system Version:
Severity: normal Keywords:
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

Take the example: sample-plugins/workflow/DeleteTicket.py

It doesn't call apply_action_side_effects unless a change is made to the ticket. And when you want to delete a ticket, as in the example, it doesn't make sense to have to change the ticket first.

I believe trac/ticket/web_ui.py needs to be modified to always call apply_action_side_effects, regardless of if any real changes have been made to the ticket.

Attachments (1)

apply_action_side_effects.patch​ (847 bytes ) - added by kirean@… 17 years ago.

Download all attachments as: .zip

Change History (5)

by kirean@…, 17 years ago

Attachment: apply_action_side_effects.patch​ added

comment:1 by kirean@…, 17 years ago

Creds to osimons.

Maybe this patch to the sample could do the trick instead?

comment:2 by Eli Carter, 17 years ago

Resolution: → fixed
Status: new → closed

It is supposed to call the side effects even if there are no changes to the ticket. Fixed in [6021].

comment:3 by Christian Boos, 12 years ago

Milestone: → 0.11
Owner: changed from Jonas Borgström to Eli Carter

(fixing {36})

comment:4 by Ryan J Ollos, 7 years ago

The r6021 functional test case rewritten in [16392:16393].

Last edited 7 years ago by Ryan J Ollos (previous) (diff)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Eli Carter.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Eli Carter to the specified user.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.