Edgewall Software
Modify ↓

Opened 7 years ago

Closed 7 years ago

#12938 closed defect (fixed)

Delete action of DeleteTicketActionController doesn't appear on batch modify

Reported by: Ryan J Ollos Owned by: Ryan J Ollos
Priority: normal Milestone: 1.2.3
Component: ticket system Version:
Severity: normal Keywords: batch-modify
Cc: Branch:
Release Notes:

Fixed some actions not available on batch modify page.

API Changes:
Internal Changes:

Description

BatchModify filters the actions to those defined in ConfigurableTicketWorkflow: tags/trac-1.2.2/trac/ticket/batch.py@:156-161#L143​.

ConfigurableTicketWorkflow only returns actions defined in trac.ini. However, DeleteTicketActionController​ appends the delete action for all users with TicketDelete, for all ticket statuses.

I think this is just an example of a more general defect. BatchModifyModule shouldn't use ConfigurableTicketWorkflow to filter the allowed actions.

Attachments (0)

Change History (3)

comment:1 by Ryan J Ollos, 7 years ago

Release Notes: modified (diff)

comment:3 by Ryan J Ollos, 7 years ago

Resolution: → fixed
Status: assigned → closed

Committed to 1.2-stable in r16388, merged to trunk in r16389.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Ryan J Ollos to the specified user.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.