Edgewall Software

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#12924 closed enhancement (fixed)

Eliminate EnvironmentSetup class

Reported by: Ryan J Ollos Owned by: Ryan J Ollos
Priority: normal Milestone: 1.3.3
Component: general Version:
Severity: normal Keywords: refactoring
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:


Follow-on to #12891. At one time the EnvironmentSetup class contained a lot of code, but we've done a lot of refactoring since: EnvironmentSetup in Trac 1.0 vs EnvironmentSetup in Trac 1.3.2.

  1. I think it makes sense to eliminate the EnvironmentSetup class created in r1840 and implement IEnvironmentSetupParticipant on DatabaseManager.
  2. In r1840 the IEnvironmentSetupParticipant for attachments and templates were added, and the environment directories for attachments and templates were created in the IEnvironmentSetupParticipant.environment_created implementations. This was changed for attachments in r11169, but persists for templates. I think it's more clear to have all the top-level environment directories created in Environment.create.

Attachments (0)

Change History (3)

comment:2 by Ryan J Ollos, 3 years ago

Keywords: refactoring added
Resolution: fixed
Status: assignedclosed

Fixed indentation error in Chrome.environment_created and committed to trunk in r16341.

comment:3 by Ryan J Ollos, 3 years ago

Documentation update in r16506.

Modify Ticket

Change Properties
Set your email in Preferences
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Ryan J Ollos to the specified user.

Add Comment

E-mail address and name can be saved in the Preferences .
Note: See TracTickets for help on using tickets.