Context Navigation

Modify ↓

#12924 closed enhancement (fixed)

Follow-on to #12891. At one time the EnvironmentSetup class contained a lot of code, but we've done a lot of refactoring since: EnvironmentSetup in Trac 1.0 vs EnvironmentSetup in Trac 1.3.2 .

I think it makes sense to eliminate the EnvironmentSetup class created in r1840 and implement IEnvironmentSetupParticipant on DatabaseManager.
In r1840 the IEnvironmentSetupParticipant for attachments and templates were added, and the environment directories for attachments and templates were created in the IEnvironmentSetupParticipant.environment_created implementations. This was changed for attachments in r11169, but persists for templates. I think it's more clear to have all the top-level environment directories created in Environment.create.

Fixed indentation error in Chrome.environment_created and committed to trunk in r16341.

Documentation update in r16506.

Change Properties

Summary:
Description:	Follow-on to #12891. At one time the `EnvironmentSetup` class contained a lot of code, but we've done a lot of refactoring since: [browser:tags/trac-1.0/trac/env.py#L726 EnvironmentSetup in Trac 1.0] vs [browser:tags/trac-1.3.2/trac/env.py#L775 EnvironmentSetup in Trac 1.3.2]. 1. I think it makes sense to eliminate the `EnvironmentSetup` class created in r1840 and implement `IEnvironmentSetupParticipant` on `DatabaseManager`. 1. In r1840 the `IEnvironmentSetupParticipant` for attachments and templates were added, and the environment directories for attachments and templates were created in the `IEnvironmentSetupParticipant.environment_created` implementations. This was changed for attachments in r11169, but persists for templates. I think it's more clear to have all the top-level environment directories created in `Environment.create`. You may use WikiFormatting here.
Type:		Priority:
Milestone:		Component:
Version:		Severity:
Keywords:		Cc:	Set your email in Preferences
Branch:
Release Notes:
API Changes:
Internal Changes:

Action

leave as closed The owner will remain Ryan J Ollos.

reopen The resolution will be deleted. Next status will be 'reopened'.

change ownership to The owner will be changed from Ryan J Ollos to the specified user.

Your email or username:

E-mail address and name can be saved in the Preferences .

You may use WikiFormatting here.

Attachments ↑ Description ↑

Note: See TracTickets for help on using tickets.