Edgewall Software
Modify

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#12923 closed defect (fixed)

Form resubmission warning on page refresh after warning added when granting permission

Reported by: Ryan J Ollos Owned by: Ryan J Ollos
Priority: normal Milestone: 1.0.17
Component: admin/web Version:
Severity: normal Keywords:
Cc: Branch:
Release Notes:

Fixed form resubmission warnings on admin pages.

API Changes:
Internal Changes:

Description

The issue appears to have been introduced in #3873 / r5227.

  • trac/admin/web_ui.py

    diff --git a/trac/admin/web_ui.py b/trac/admin/web_ui.py
    index acbbd22d5..5d1aad79c 100644
    a b class PermissionAdminPanel(Component):  
    389389                    add_notice(req, _("The subject %(subject)s has been "
    390390                                      "granted the permission %(action)s.",
    391391                                      subject=subject, action=action))
    392                     req.redirect(req.href.admin(cat, page))
    393392                else:
    394393                    add_warning(req, _("The permission %(action)s was already "
    395394                                       "granted to %(subject)s.",
    396395                                       action=action, subject=subject))
     396                req.redirect(req.href.admin(cat, page))
    397397
    398398            # Add subject to group
    399399            elif req.args.get('add') and subject and group:
    class PermissionAdminPanel(Component):  
    416416                    add_notice(req, _("The subject %(subject)s has been added "
    417417                                      "to the group %(group)s.",
    418418                                      subject=subject, group=group))
    419                     req.redirect(req.href.admin(cat, page))
    420419                else:
    421420                    add_warning(req, _("The subject %(subject)s was already "
    422421                                       "added to the group %(group)s.",
    423422                                       subject=subject, group=group))
     423                req.redirect(req.href.admin(cat, page))
    424424
    425425            # Remove permissions action
    426426            elif req.args.get('remove') and req.args.get('sel'):

Attachments (1)

Screen Shot 2017-09-25 at 16.48.00.png (115.1 KB ) - added by Ryan J Ollos 3 years ago.

Download all attachments as: .zip

Change History (5)

by Ryan J Ollos, 3 years ago

comment:1 by Ryan J Ollos, 3 years ago

Summary: Form resubmission warning after warning added when granting permissionForm resubmission warning on page refresh after warning added when granting permission

comment:2 by Ryan J Ollos, 3 years ago

Committed to 1.0-stable in [16338:16340]. I thought changes would be simple but kept discovering more issues on 3rd, 4th … rounds of testing.

I'll revisit in a few days and merge changes if no other issues are found.

comment:3 by Ryan J Ollos, 3 years ago

Release Notes: modified (diff)
Resolution: fixed
Status: assignedclosed

Merged to 1.2-stable in r16344, merged to trunk in r16345.

comment:4 by Ryan J Ollos, 3 years ago

Milestone: 1.0.161.0.17

Milestone renamed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Ryan J Ollos to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.