Refactor do_initenv method

[Ryan J Ollos]

IEnvironmentSetupParticipant.environment_created is used to do some of the work in creating an environment:

• tags/trac-1.3.2/trac/ticket/default_workflow.py@:140#L138​
• tags/trac-1.3.2/trac/ticket/notification.py@:45#L43​
• tags/trac-1.3.2/trac/web/chrome.py@:688#L686​

However, there is an inconsistency in that other module-specific operations are done in console.py​:

• Loading default pages
• Synchronizing the default repository
• Adding default values for [mainnav] and [metanav] sections

It seems like that work should be moved to IEnvironmentSetupParticipant implementations.

[Ryan J Ollos]

With svn and git in tracopt, repositories can only be synchronized on environment creation if --inherit or --config is used to enable the components. Example:

[components]
tracopt.versioncontrol.* = enabled

[git]
cached_repository = true

[repositories]
repos1.type = git
repos1.dir = /Users/rjollos/Documents/Workspace/trac-dev/repos/git/repos1
repos2.type = svn
repos2.dir = /Users/rjollos/Documents/Workspace/trac-dev/repos/svn/proj1
.type = direct-svnfs
.dir = /Users/rjollos/Documents/Workspace/trac-dev/repos/svn/proj2

Therefore:

• I think it makes sense to synchronize all repositories on environment creation, not just the default, since multiple repositories can be specified in the --inherit or --config file.
• The initenv arguments <repostype> and <repospath> have very limited usefulness:
  • Trac is multi-repository and they only allow setting the default repository
  • Unless the version control components are enabled, the only effect is to add the options to the config. The repositories are not available because the connector is not enabled, and the repositories are not synced.

The arguments probably should have been at least deprecated with the addition of multi-repository in 0.12. I think it makes sense to just remove the arguments so as to not confuse the user with all the caveats involved with using the arguments. This will be a backward-incompatible change, so let me know if it will cause you problems.

Changes in log:rjollos.git:t12891_refactor_initenv.

[Ryan J Ollos]

Committed to trunk in r16244 and r16245. I'll propose additional related changes later on, probably for milestone:1.5.1.

Documentation updated in 1.3/TracEnvironment@2.

[Ryan J Ollos]

Additional documentation updates related to configuration in comment:1:

• 1.3/TracRepositoryAdmin@9.
• 1.3/TracEnvironment@3
• 1.3/TracUpgrade@23.

[Ryan J Ollos]

See also #13290 for a change that should have been done here.