Edgewall Software
Modify

Opened 2 years ago

Closed 7 months ago

#12752 closed defect (fixed)

Broken layout of TicketQuery macro in grouped table mode

Reported by: Christian Boos Owned by:
Priority: normal Milestone: 1.3.4
Component: query system Version: 1.3dev
Severity: normal Keywords: layout
Cc: Branch: cboos.git@t12752-grouped-query
Release Notes:

Fix a visual glitch in the way the first group in a TracQuery tabular results is presented.

API Changes:

Description

Looking at TracDev/ReleaseNotes/1.2#DetailedUserVisibleChanges, we see that the first <h2> for the Component: admin/console group doesn't have the same positioning as the others.

This is not so surprising considering the generated HTML:

<h2 class="section" id="DetailedUserVisibleChanges">Trac 1.2: Detailed User Visible Changes</h2>
<p>
</p>

<div>


    <h2 class="report-result" >
Component: admin/console     <span class="numrows">
      (2 matches)
    </span>
    </h2>


  <table class="listing tickets">
    <thead>
            <tr class="trac-columns">
        <th class="id asc">
          <a title="Sort by Ticket (descending)"
             href="/query?status=closed&amp;milestone=1.2&amp;milestone=1.1.1&amp;milestone=1.1.2&amp;milestone=1.1.3&amp;milestone=1.1.4&amp;milestone=1.1.5&amp;milestone=1.1.6&amp;severity=!trivial&amp;severity=!minor&amp;changelog=!&amp;group=component&amp;max=0&amp;col=id&amp;col=changelog&amp;desc=1&amp;order=id">Ticket</a>
        </th>
        <th class="changelog">
          <a title="Sort by Release Notes (ascending)"
             href="/query?status=closed&amp;milestone=1.2&amp;milestone=1.1.1&amp;milestone=1.1.2&amp;milestone=1.1.3&amp;milestone=1.1.4&amp;milestone=1.1.5&amp;milestone=1.1.6&amp;severity=!trivial&amp;severity=!minor&amp;changelog=!&amp;group=component&amp;max=0&amp;col=id&amp;col=changelog&amp;order=changelog">Release Notes</a>
        </th>
      </tr>

    </thead>

    <tbody>
      <tr class="odd prio3">
        <td class="id"><a href="/ticket/11333" title="View ticket" class="closed">#11333</a></td>
        <td class="changelog">
          <p>
The <a class="wiki" href="/wiki/TracAdmin">TracAdmin</a> <code>initenv</code> command accepts an optional parameter <code>--config</code>, the path to a file containing a configuration to be used when creating the environment.
</p>

        </td>
      </tr>      <tr class="even prio3">
        <td class="id"><a href="/ticket/11938" title="View ticket" class="closed">#11938</a></td>
        <td class="changelog">
          <p>
Improved error message when adding and removing an invalid action with <a class="wiki" href="/wiki/TracAdmin">TracAdmin</a>.
</p>

        </td>
      </tr>      </tbody>
    <tbody>
      <tr class="trac-group">
        <th colspan="2">
            <h2 class="report-result" >
Component: admin/web     <span class="numrows">
      (7 matches)
    </span>
    </h2>

        </th>
      </tr>
            <tr class="trac-columns">
        <th class="id asc">
          <a title="Sort by Ticket (descending)"
             href="/query?status=closed&amp;milestone=1.2&amp;milestone=1.1.1&amp;milestone=1.1.2&amp;milestone=1.1.3&amp;milestone=1.1.4&amp;milestone=1.1.5&amp;milestone=1.1.6&amp;severity=!trivial&amp;severity=!minor&amp;changelog=!&amp;group=component&amp;max=0&amp;col=id&amp;col=changelog&amp;desc=1&amp;order=id">Ticket</a>
        </th>
        <th class="changelog">
          <a title="Sort by Release Notes (ascending)"
             href="/query?status=closed&amp;milestone=1.2&amp;milestone=1.1.1&amp;milestone=1.1.2&amp;milestone=1.1.3&amp;milestone=1.1.4&amp;milestone=1.1.5&amp;milestone=1.1.6&amp;severity=!trivial&amp;severity=!minor&amp;changelog=!&amp;group=component&amp;max=0&amp;col=id&amp;col=changelog&amp;order=changelog">Release Notes</a>
        </th>
      </tr>

    </tbody>

IIRC, this odd output (already there on 1.2.x and probably from the start) was motivated by the need to define a correct <thead> with only the column headings.

So we either need to fix the CSS to harmonize this (the .wikipage table h1, .wikipage table h2, .wikipage table h3 { margin-left: -2rem; ... is the problem), or come with a better HTML output.

I don't have a solution in mind yet.

Attachments (0)

Change History (5)

comment:1 by Ryan J Ollos, 2 years ago

Milestone: 1.3.21.3.3

comment:2 by Ryan J Ollos, 23 months ago

Milestone: 1.3.31.4

comment:3 by Christian Boos, 8 months ago

Branch: t12752-grouped-query

I tried different things, and using the <caption> seems the only way to get something in the <table> before the <thead>.

comment:4 by Christian Boos, 8 months ago

Branch: t12752-grouped-query[log:cboos.git@t12752-grouped-query]

comment:5 by Christian Boos, 7 months ago

Milestone: 1.41.3.4
Release Notes: modified (diff)
Resolution: fixed
Status: newclosed

Commits from the branch committed in [16878:16880].

The first changeset specifically fixes the issue reported here, while the last two are further improvements to the content of TracQuery tabular results.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The ticket will remain with no owner.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.