TypeError: unicode argument expected, got 'str'

[anonymous]

Creating a new report with an empty query field:

Traceback (most recent call last):
  File "/trac/trunk/trac/web/main.py", line 630, in _dispatch_request
    dispatcher.dispatch(req)
  File "/trac/trunk/trac/web/main.py", line 252, in dispatch
    resp = chosen_handler.process_request(req)
  File "/trac/trunk/trac/ticket/report.py", line 190, in process_request
    template, data, content_type = self._render_view(req, id)
  File "/trac/trunk/trac/ticket/report.py", line 422, in _render_view
    res = self.execute_paginated_report(req, id, sql, args, limit, offset)
  File "/trac/trunk/trac/ticket/report.py", line 659, in execute_paginated_report
    sql, args, missing_args = self.sql_sub_vars(sql, args)
  File "/trac/trunk/trac/ticket/report.py", line 846, in sql_sub_vars
    sql_io.write(sub_vars_re.sub(repl, expr))
TypeError: unicode argument expected, got 'str'

[Ryan J Ollos]

This appears to be due to changes in #12046. It seems to be fixed with either of these patches:

trac/ticket/model.py

@@ -1167 +1167 @@
                         WHERE id=%s
                         """, (id_as_int,)):
                     self.id = id_as_int
-                    self.title = title or ''
-                    self.description = description or ''
-                    self.query = query or ''
+                    self.title = title or u''
+                    self.description = description or u''
+                    self.query = query or u''
                     return
             raise ResourceNotFound(_("Report {%(num)s} does not exist.",
                                      num=id), _("Invalid Report Number"))

trac/ticket/report.py

@@ -843 +843 @@
                 if expr.startswith("'"):
                     sql_io.write(repl_literal(expr, db))
                 else:
-                    sql_io.write(sub_vars_re.sub(repl, expr))
+                    sql_io.write(sub_vars_re.sub(repl, unicode(expr)))
 
         # Remove arguments that don't appear in the SQL query
         for name in set(args) - names:

Is one of those preferred, or is there an even better fix? I'll add a unit test before committing.

[Ryan J Ollos]

Fixed in r15593, however I think we should preventing allowing to create a report with empty SQL query.

[Jun Omae]

When no SQL query error occurs, Edit and Delete buttons would be invisible. The buttons should be visible.

[Ryan J Ollos]

Replying to Ryan J Ollos:

Fixed in r15593, however I think we should preventing allowing to create a report with empty SQL query.

Simplest way to avoid empty query would be:

trac/ticket/model.py

@@ -1189 +1189 @@
     def insert(self):
         """Insert a new report."""
         assert not self.exists, "Cannot insert existing report"
+        if not self.query:
+            raise TracError(_("Query cannot be empty."))
 
         self.env.log.debug("Creating new report '%s'", self.id)
         with self.env.db_transaction as db:
@@ -1199 +1201 @@
             self.id = db.get_last_id(cursor, 'report')
 
     def update(self):
+        if not self.query:
+            raise TracError(_("Query cannot be empty."))
         self.env.db_transaction("""
             UPDATE report SET title=%s, query=%s, description=%s
             WHERE id=%s

I think it would be good to add a warning instead, but we should make those changes throughout TRac. For example, when adding a milestone with empty name.

[Ryan J Ollos]

Replying to Jun Omae:

When no SQL query error occurs, Edit and Delete buttons would be invisible. The buttons should be visible.

Agreed, but that is unrelated to the regression and 1.2-stable has same issue. We can avoid by preventing saving a report with an empty query.

[Jun Omae]

Replying to Ryan J Ollos:

Replying to Jun Omae:

When no SQL query error occurs, Edit and Delete buttons would be invisible. The buttons should be visible.

Agreed, but that is unrelated to the regression and 1.2-stable has same issue.

Yeah. I'll create new ticket for invisible buttons. → #12709

We can avoid by preventing saving a report with an empty query.

Minor thing, we cannot avoid empty saved query before the fix. I manually added ?action=edit to URL.

[Ryan J Ollos]

Replying to Jun Omae:

We can avoid by preventing saving a report with an empty query.

Minor thing, we cannot avoid empty saved query before the fix. I manually added ?action=edit to URL.

Good point. I think it's a good idea to show those buttons on the page even when an error is raised.

[Ryan J Ollos]

comment:6 changes committed to 1.2-stable in r15598, merged to trunk in r15599.