Edgewall Software
Modify ↓

Opened 7 years ago

Closed 7 years ago

#12709 closed defect (fixed)

Unable to edit/delete report with no SQL query

Reported by: Jun Omae Owned by: Jun Omae
Priority: normal Milestone: 1.2.1
Component: report system Version:
Severity: normal Keywords:
Cc: Branch:
Release Notes:

Buttons in report view are available even when no query.

API Changes:
Internal Changes:

Description

(comment:5:ticket:12704)

When report with no SQL query is shown, TracError is raised. However, edit and delete buttons are unavailable. The error couldn't be solved.

We should show the buttons when error is raised.

Attachments (0)

Change History (4)

comment:1 by Jun Omae, 7 years ago

Owner: set to Jun Omae
Status: new → assigned

Proposed changes in [06ad22c27/jomae.git] (jomae.git@t12709).

comment:2 by Ryan J Ollos, 7 years ago

Changes look good. On trunk _insert_report was added to ReportModuleTestCase in r15599. The method could be added on 1.2-stable and used to simplify test cases slightly. Also self.assertEqual(True ⇒ self.assertTrue( replacements could be made.

comment:3 by Jun Omae, 7 years ago

Thanks for the reviewing!

Okay. In this case we could use self.assertTrue.

comment:4 by Jun Omae, 7 years ago

Release Notes: modified (diff)
Resolution: → fixed
Status: assigned → closed

Fixed in [15605] and merged in [15606].

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Jun Omae.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Jun Omae to the specified user.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.