Ticket query Columns checkboxes are reordered

[Ryan J Ollos]

To reproduce:

1. Go to ticket query page and view the columns.

2. Add Keywords to query filters.
3. Update and view columns again.

Is there a reason I should expect the Columns checkboxes to reorder?

[Jun Omae]

This behavior is intentionally implemented in Query.get_all_column() at tags/trac-1.2/trac/ticket/query.py@:226-238#L217​. We could simply rewrite the Query.get_all_column() like:

trac/ticket/query.py

@@ -223 +223 @@
                 cols.remove(col)
                 cols.append(col)
 
-        def sort_columns(col1, col2):
-            constrained_fields = self.constraint_cols.keys()
-            if 'id' in (col1, col2):
-                # Ticket ID is always the first column
-                return -1 if col1 == 'id' else 1
-            elif 'summary' in (col1, col2):
-                # Ticket summary is always the second column
-                return -1 if col1 == 'summary' else 1
-            elif col1 in constrained_fields or col2 in constrained_fields:
-                # Constrained columns appear before other columns
-                return -1 if col1 in constrained_fields else 1
-            return 0
-        cols.sort(sort_columns)
+        constrained_fields = set(self.constraint_cols)
+        def sort_columns(name):
+            if name == 'id':
+                return 1  # Ticket ID is always the first column
+            if name == 'summary':
+                return 2  # Ticket summary is always the second column
+            if name in constrained_fields:
+                return 3  # Constrained columns appear before other columns
+            return 4
+        cols.sort(key=sort_columns)
         return cols

[Ryan J Ollos]

Thanks, that change works well.

[Ryan J Ollos]

I see we did a similar refactoring on the trunk in r15332.