Edgewall Software
Modify

Opened 3 years ago

Closed 3 years ago

#12701 closed enhancement (fixed)

Add wikitext class to input text fields

Reported by: Ryan J Ollos Owned by: Ryan J Ollos
Priority: normal Milestone: 1.2.1
Component: wiki system Version:
Severity: normal Keywords:
Cc: Branch:
Release Notes:

Added wikitext class to input fields that accept wiki markup.

API Changes:

Description

The proposed change is to add the wikitext class to any input text field that accepts wiki markup. For example:

  • trac/wiki/templates/wiki_edit_form.html

    diff --git a/trac/wiki/templates/wiki_edit_form.html b/trac/wiki/templates/wiki_edit_form.html
    index b6f39effd..82b1146e9 100644
    a b $page.text</textarea>  
    6060        </div>
    6161        <div class="field">
    6262          <label>Comment about this change (optional):<br />
    63             <input id="comment" type="text" class="trac-fullwidth" name="comment" value="$comment" />
     63            <input id="comment" type="text" class="trac-fullwidth wikitext" name="comment" value="$comment" />
    6464          </label>
    6565        </div>
    6666      </div>

This would support autocompleting wiki text in those fields for WikiAutoCompletePlugin (#13068).

Attachments (0)

Change History (5)

comment:1 by anonymous, 3 years ago

Searching for <input.*input"text" finds 85 matches in 33 files. Most are not relevant.

So I think the main ones are: attachment description, milestone retarget comment, and wiki page comment.

The only other more questionable candidates I can see are search, ticket and query fields, but those would require more investigation.

in reply to:  1 comment:2 by Peter Suter, 3 years ago

(Forgot to log in.)

Searching for <input.*input"text" finds 85 matches in 33 files. Most are not relevant.

That should say <input.*type="text".

in reply to:  1 comment:3 by Ryan J Ollos, 3 years ago

Replying to anonymous:

So I think the main ones are: attachment description, milestone retarget comment, and wiki page comment.

Thanks, I overlooked milestone retarget comment. I think it makes sense for ticket fields with wiki formatting as well, but only on the ticket page and not the query page.

comment:4 by Ryan J Ollos, 3 years ago

Milestone: next-stable-1.2.x1.2.1
Owner: set to Ryan J Ollos
Status: newassigned

comment:5 by Ryan J Ollos, 3 years ago

Release Notes: modified (diff)
Resolution: fixed
Status: assignedclosed

Committed to 1.2-stable in r15594, merged to trunk in r15595.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.
to as closed The owner will be changed from Ryan J Ollos to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.