Add wikitext class to input text fields

[Ryan J Ollos]

The proposed change is to add the wikitext class to any input text field that accepts wiki markup. For example:

trac/wiki/templates/wiki_edit_form.html

@@ -60 +60 @@
         </div>
         <div class="field">
           <label>Comment about this change (optional):<br />
-            <input id="comment" type="text" class="trac-fullwidth" name="comment" value="$comment" />
+            <input id="comment" type="text" class="trac-fullwidth wikitext" name="comment" value="$comment" />
           </label>
         </div>
       </div>

This would support autocompleting wiki text in those fields for ​WikiAutoCompletePlugin (​#13068).

[anonymous]

Searching for <input.*input"text" finds 85 matches in 33 files. Most are not relevant.

• admin_basics.html​ (project name, url)
• admin_logging.html​ (log file)
• admin_perms.html​ (permission subjects, groups and targets)
• query.js​ (custom ticket query?)
• prefs_advanced.html​ (session id)
• prefs_general.html​ (user name, email)
• search.html​ (search?)
• attachment.html​ (author, description)
• diff_options.html​ (number of context lines)
• genshi/attachment.html (author, description)
• genshi/diff_options.html (number of context lines)
• genshi/theme.html (search?)
• theme.html​ (search?)
• admin_components.html​ (owner, name)
• admin_enums.html​ (name)
• admin_milestones.html​ (name, due date)
• admin_versions.html​ (name, released date)
• milestone_edit_form.html​ (name, due date, completed date, retarget comment)
• query.html​ (custom ticket query?, max)
• report_edit.html​ (title)
• report_view.html​ (max, report arguments)
• ticket.html​ (summary, reporter, misc fields?, author)
• tests/.../default_workflow.py​
• tests/.../main.py​
• timeline.html​ (from date, days back, authors)
• admin_repositories.html​ (name, directory, url)
• browser.html​ (old, rev)
• diff_form.html​ (old path, old rev, new path, new rev)
• revisionlog.html​ (rev, stop rev, limit)
• default-pages/WikiProcessors​
• wiki_edit_comment.html​ (new comment)
• wiki_edit_form.html​ (author, comment)
• wiki_rename.html​ (new name)

So I think the main ones are: attachment description, milestone retarget comment, and wiki page comment.

The only other more questionable candidates I can see are search, ticket and query fields, but those would require more investigation.

[Peter Suter]

(Forgot to log in.)

Searching for <input.*input"text" finds 85 matches in 33 files. Most are not relevant.

That should say <input.*type="text".

[Ryan J Ollos]

Replying to anonymous:

So I think the main ones are: attachment description, milestone retarget comment, and wiki page comment.

Thanks, I overlooked milestone retarget comment. I think it makes sense for ticket fields with wiki formatting as well, but only on the ticket page and not the query page.

[Ryan J Ollos]

Proposed changes in rjollos.git:t12701_wikitext_class_1.2_stable and rjollos.git:t12701_wikitext_class_trunk.

[Ryan J Ollos]

Committed to 1.2-stable in r15594, merged to trunk in r15595.