WikiFormatting leaking to HTML

[anonymous]

When a user writes a wrong WikiFormatting syntax inside a textarea that accepts the WikiFormatting, the formatting rule "leaks" to the subsequent HTML and the ticket cannot be updated. A message that the ticket was modified by another user is displayed.

Example: demo-1.0:#5040

54******94
Vl

       C
54******94

[Ryan J Ollos]

See also #11009. Need to confirm issue exists also for 1.0-stable.

[anonymous]

Reproduced on demo-1.0 (1.0.14.dev0): https://trac.edgewall.org/demo-1.0/ticket/5040

[Christian Boos]

There might be a quick fix on the current code base, if anyone wants to tackle it, feel free.

Otherwise, I'll try to fix it by reworking the HTML generation in the wiki Formatter, just got an idea this morning ;-)

[anonymous]

Any updates?

[Jun Omae]

Inline markup after indent line leads this issue:

>>> import trac
>>> trac.__version__
'1.0.13'
>>> from trac.mimeview.api import RenderingContext
>>> from trac.resource import Resource
>>> from trac.test import EnvironmentStub
>>> from trac.test import MockRequest
>>> from trac.wiki.formatter import Formatter, format_to_html
>>> resource = Resource('wiki', 'WikiStart')
>>> env = EnvironmentStub()
>>> req = MockRequest(env)
>>> context = RenderingContext(resource, req.href, req.perm)
>>> context.req = req
>>> print(format_to_html(env, context, """\
... 54******94
... Vl
...
...        C
... 54******94
... """))
<p>
54<strong></strong><strong>94
Vl
</strong></p>
<blockquote>
<p>
C
</strong></p>
</blockquote>
<p>
54<strong></strong><strong>94
</p>

>>> print(format_to_html(env, context, """\
...   indent
... **
... """))
<blockquote>
<p>
indent
</strong></p>            # <== unbalanced </strong>
</blockquote>
<p>
<strong>                 # <== missing </strong>
</p>

[Jun Omae]

Proposed changes in [eb347148a/jomae.git] (jomae.git@t12675). Also, I noticed similar issue #11009.

After the changes:

>>> print(format_to_html(env, context, """\
... 54******94
... Vl
...
...        C
... 54******94
... """))
<p>
54<strong></strong><strong>94
Vl
</strong></p>
<blockquote>
<p>
C
</p>
</blockquote>
<p>
54<strong></strong><strong>94
</strong></p>

>>> print(format_to_html(env, context, """\
...   indent
... **
... """))
<blockquote>
<p>
indent
</p>
</blockquote>
<p>
<strong>
</strong></p>

[Jun Omae]

Replying to Jun Omae:

Proposed changes in [eb347148a/jomae.git] (jomae.git@t12675). Also, I noticed similar issue #11009.

Could someone please review the changes?

p.s. I've attempted to move fix for #11009 to _format_line added in [eb347148a/jomae.git] but that's unsuccessful.

[Peter Suter]

Have you considered something like this?

trac/wiki/formatter.py

@@ -1319 +1319 @@
             if not line.startswith(' '):
                 self._tabstops = []
 
+            # Handle end of indentation
+            if not line.startswith(' ') and self._quote_stack:
+                self.close_indentation()
+
             self.in_list_item = False
             self.in_quote = False
             # Throw a bunch of regexps on the problem

It seems simpler and passing the tests.

[Jun Omae]

Thanks for the review! Revised jomae.git@t12675 and verified unit tests passing.

[wbruna]

On our install (Trac 1.0.1, Debian Wheezy package), [eb347148a/jomae.git] together with the patch from #11009 seems to fix this issue.

[Jun Omae]

Committed in [15687] and merged in [15688-15689].