TypeError: 'unicode' does not have the buffer interface

[Ryan J Ollos]

Found in the logs:

2017-01-26 09:57:35,825 Trac[main] ERROR: Internal Server Error: <RequestWithSession "GET '/roadmap?format=ics'">, referrer None
Traceback (most recent call last):
  File "build/bdist.linux-x86_64/egg/trac/web/main.py", line 630, in _dispatch_request
    dispatcher.dispatch(req)
  File "build/bdist.linux-x86_64/egg/trac/web/main.py", line 252, in dispatch
    resp = chosen_handler.process_request(req)
  File "build/bdist.linux-x86_64/egg/trac/ticket/roadmap.py", line 511, in process_request
    self._render_ics(req, milestones)
  File "build/bdist.linux-x86_64/egg/trac/ticket/roadmap.py", line 598, in _render_ics
    self.env.project_name + ' - ' + _("Roadmap"))
  File "build/bdist.linux-x86_64/egg/trac/ticket/roadmap.py", line 578, in write_prop
    buf.write(text[:75] + CRLF)
TypeError: 'unicode' does not have the buffer interface 

[Christian Boos]

Looks like in r15010, an io.BytesIO() was used where it should have been a io.StringIO().

This, plus a to_unicode() in write_prop(), as it seems that io.StringIO() is quite picky…

trac/ticket/roadmap.py

@@ -533 +533 @@
     def _render_ics(self, req, milestones):
         req.send_response(200)
         req.send_header('Content-Type', 'text/calendar;charset=utf-8')
-        buf = io.BytesIO()
+        buf = io.StringIO()
 
         from trac.ticket import Priority
         priorities = {}
@@ -570 +570 @@
                                                   in params.items()]) + \
                    ':' + escape_value(value)
             firstline = 1
+            text = to_unicode(text)
             while text:
                 if not firstline:
                     text = ' ' + text

[Christian Boos]

Applied in r15402.

[Ryan J Ollos]

Added test coverage in r15498.