Edgewall Software
Modify

Opened 23 months ago

Closed 22 months ago

Last modified 17 months ago

#12671 closed defect (fixed)

It is difficult to click Reply and Edit buttons in ticket change when only properties are changed

Reported by: Jun Omae Owned by: Jun Omae
Priority: normal Milestone: 1.2.1
Component: ticket system Version:
Severity: normal Keywords:
Cc:
Release Notes:

Improve usability of Reply and Edit buttons associated with ticket comments

API Changes:

Description (last modified by Jun Omae)

Since Trac 1.2, Reply and Edit buttons in ticket change are shown when cursor is hovered in the ticket change.

However, when the ticket change has only properties changes and no comment, the buttons are shown only when cursor is hovered in property changes box. As the results, it is difficult to click the buttons.

Live demo: demo-1.2/ticket/2

Work around to make the buttons visible when cursor is hovered in entire of div.change:

  • trac/htdocs/css/ticket.css

    diff --git a/trac/htdocs/css/ticket.css b/trac/htdocs/css/ticket.css
    index 13cbb1ed1..a4ca88c71 100644
    a b ul.children > li.child {  
    219219 box-shadow: .1em .2em 1em #eee;
    220220}
    221221div.change, ul.children { clear: both; }
     222div.change:after {
     223 content: "";
     224 display: block;
     225 clear: both;
     226 height: 0;
     227}
    222228
    223229.changes th {
    224230 text-align: right;

Attachments (1)

hover.png (89.6 KB ) - added by Jun Omae 23 months ago.

Download all attachments as: .zip

Change History (10)

Changed 23 months ago by Jun Omae

Attachment: hover.png added

comment:1 Changed 23 months ago by Jun Omae

Description: modified (diff)

comment:2 in reply to:  description Changed 23 months ago by Christian Boos

Replying to Jun Omae:

… the buttons are shown only when cursor is hovered in property changes box. As the results, it is difficult to click the buttons.

But also the whole <h3> line as well, in particular the comment:n part which is just above the buttons. But I think you're right anyway, it's not as obvious as it should be.

If you remember my idea presented recently on trac-dev about a "page menu" (gmessage:trac-dev:eVU0q8Tatgo/pokz_FIyEQAJ), I think it could be transposed here as well: we would have a permanent menu reminder character/icon (▤, ≣), which would show the list of actions for the comment when hovered / clicked.

Something like:

comment:n Modified by Author

comment:3 Changed 23 months ago by Ryan J Ollos

comment:4 Changed 22 months ago by Christian Boos

comment:5 Changed 22 months ago by Christian Boos

Release Notes: modified (diff)
Resolution: fixed
Status: newclosed

I've applied your suggestion on 1.2-stable in r15522.

However for trunk, I'd rather go with what I'll do with the new "action menu" (#12685). So I didn't merge this change up for now, we'll see how this works out.

comment:6 Changed 22 months ago by Ryan J Ollos

Owner: set to Jun Omae

comment:7 Changed 17 months ago by Jun Omae

It seems that the same issue has not fixed on trunk yet. r15522 has been merged as record-only in r15558.

Last edited 17 months ago by Jun Omae (previous) (diff)

comment:8 Changed 17 months ago by Ryan J Ollos

I agree we should merge the fix unless #12685 (comment:5) will be fixed for milestone:1.4.

comment:9 Changed 17 months ago by Jun Omae

Thanks. Committed in r16111.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Jun Omae.
The resolution will be deleted.
to The owner will be changed from Jun Omae to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.