Edgewall Software
Modify ↓

Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#12671 closed defect (fixed)

It is difficult to click Reply and Edit buttons in ticket change when only properties are changed

Reported by: Jun Omae Owned by: Jun Omae
Priority: normal Milestone: 1.2.1
Component: ticket system Version:
Severity: normal Keywords:
Cc: Branch:
Release Notes:

Improve usability of Reply and Edit buttons associated with ticket comments

API Changes:
Internal Changes:

Description (last modified by Jun Omae)

Since Trac 1.2, Reply and Edit buttons in ticket change are shown when cursor is hovered in the ticket change.

However, when the ticket change has only properties changes and no comment, the buttons are shown only when cursor is hovered in property changes box. As the results, it is difficult to click the buttons.

Live demo: demo-1.2/ticket/2

Work around to make the buttons visible when cursor is hovered in entire of div.change:

  • trac/htdocs/css/ticket.css 

    diff --git a/trac/htdocs/css/ticket.css b/trac/htdocs/css/ticket.css
index 13cbb1ed1..a4ca88c71 100644
    a b ul.children > li.child {  
    219219 box-shadow: .1em .2em 1em #eee;
    220220}
    221221div.change, ul.children { clear: both; }
     222div.change:after {
     223 content: "";
     224 display: block;
     225 clear: both;
     226 height: 0;
     227}
    222228
    223229.changes th {
    224230 text-align: right;

Attachments (1)

hover.png​ (89.6 KB ) - added by Jun Omae 8 years ago.

Download all attachments as: .zip

Change History (10)

by Jun Omae, 8 years ago

Attachment: hover.png​ added

comment:1 by Jun Omae, 8 years ago

Description: modified (diff)

in reply to:  description comment:2 by Christian Boos, 8 years ago

Replying to Jun Omae:

… the buttons are shown only when cursor is hovered in property changes box. As the results, it is difficult to click the buttons.

But also the whole <h3> line as well, in particular the comment:n part which is just above the buttons. But I think you're right anyway, it's not as obvious as it should be.

If you remember my idea presented recently on trac-dev about a "page menu" (​gmessage:trac-dev:eVU0q8Tatgo/pokz_FIyEQAJ), I think it could be transposed here as well: we would have a permanent menu reminder character/icon (▤, ≣), which would show the list of actions for the comment when hovered / clicked.

Something like:

comment:n Modified by Author

≣

comment:4 by Christian Boos, 8 years ago

See also ticket:12639#comment:17.

comment:5 by Christian Boos, 8 years ago

Release Notes: modified (diff)
Resolution: → fixed
Status: new → closed

I've applied your suggestion on 1.2-stable in r15522.

However for trunk, I'd rather go with what I'll do with the new "action menu" (#12685). So I didn't merge this change up for now, we'll see how this works out.

comment:6 by Ryan J Ollos, 8 years ago

Owner: set to Jun Omae

comment:7 by Jun Omae, 7 years ago

It seems that the same issue has not fixed on trunk yet. r15522 has been merged as record-only in r15558.

Last edited 7 years ago by Jun Omae (previous) (diff)

comment:8 by Ryan J Ollos, 7 years ago

I agree we should merge the fix unless #12685 (comment:5) will be fixed for milestone:1.4.

comment:9 by Jun Omae, 7 years ago

Thanks. Committed in r16111.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Jun Omae.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Jun Omae to the specified user.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.