Test failure with test_get_search_results_matches_all_terms

[Ryan J Ollos]

Here is the output from a TravisCI test failure:

======================================================================
FAIL: test_get_search_results_matches_all_terms (trac.ticket.tests.roadmap.MilestoneModuleTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/travis/build/edgewall/trac/trac/ticket/tests/roadmap.py", line 201, in test_get_search_results_matches_all_terms
    self.assertEqual(milestone.description, results[0][4])
AssertionError: u'a326e942 malapplication dyce renounce nonqualification stackful Amphion upbring defectibility theriotrophical unsanctimoniousness haemoconcentration terrine ochlocratically thyroideal shoaly rivalry pseudosatirical nonappealable Pleuronectes.' != u'a326e942 malapplication dyce renounce nonqualification stackful Amphion upbring defectibility theriotrophical unsanctimoniousness haemoconcentration terrine ochlocratically thyroideal shoaly rivalry pseudosatirical nonappealable Pleuronect ...'

[Jun Omae]

That failure occurs when random_sentence() generates text over 240 characters. Snippet of the searching result would be shorten with 240 characters. However, I don't think we need random text in the unit tests.

trac/ticket/tests/roadmap.py

@@ -18 +18 @@
 from trac.core import ComponentManager
 from trac.resource import ResourceNotFound
 from trac.test import EnvironmentStub, MockRequest
-from trac.tests.contentgen import random_sentence
 from trac.ticket.model import Ticket
 from trac.ticket.roadmap import (
     DefaultTicketGroupStatsProvider, Milestone, MilestoneModule,
@@ -158 +157 @@
             m = Milestone(self.env)
             m.name = term
             m.due = datetime_now(utc)
-            m.description = random_sentence()
+            m.description = u"""\
+Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod \
+tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim \
+veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea \
+commodo consequat. Duis aute irure dolor in reprehenderit in voluptate \
+velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat \
+cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id \
+est laborum."""
             m.insert()
 
     def tearDown(self):
@@ -198 +204 @@
         self.assertEqual('Milestone ' + milestone.name, results[0][1])
         self.assertEqual(milestone.due, results[0][2])
         self.assertEqual('', results[0][3])
-        self.assertEqual(milestone.description, results[0][4])
+        shorten_desc = u"""\
+Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod \
+tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, \
+quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo \
+consequat. Duis a ..."""
+        self.assertEqual(shorten_desc, results[0][4])
 
     def test_get_search_results_matches_ignorecase(self):
         req = MockRequest(self.env)

[Ryan J Ollos]

That change looks good to me.

[Jun Omae]

Thanks. Committed in [15266] and merged in [15267-15268].