Edgewall Software

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#12623 closed defect (fixed)

TypeError after submitting on modify-comment form for removed comment

Reported by: Jun Omae Owned by: Jun Omae
Priority: normal Milestone: 1.0.14
Component: ticket system Version: 1.0.11
Severity: normal Keywords:
Cc: Branch:
Release Notes:

Raise a TracError when ticket's comment to edit is missing.

API Changes:
Internal Changes:


How to reproduce:

  1. Click Edit button on ticket's comment and modify-comment form would be shown
  2. Remove the ticket's comment from another window
  3. Click Submit changes button on the modify-comment form
Traceback (most recent call last):
  File "/venv/lib/python2.6/site-packages/trac/web/main.py", line 554, in _dispatch_request
  File "/venv/lib/python2.6/site-packages/trac/web/main.py", line 247, in dispatch
    resp = chosen_handler.process_request(req)
  File "/venv/lib/python2.6/site-packages/trac/ticket/web_ui.py", line 181, in process_request
    return self._process_ticket_request(req)
  File "/venv/lib/python2.6/site-packages/trac/ticket/web_ui.py", line 578, in _process_ticket_request
    ticket.modify_comment(change['date'], req.authname, comment)
TypeError: 'NoneType' object is unsubscriptable

Attachments (0)

Change History (3)

comment:1 by Jun Omae, 5 years ago

Owner: set to Jun Omae
Status: newassigned

Proposed changes in [1d9245214/jomae.git].

comment:2 by Ryan J Ollos, 5 years ago

Looks good to me.

comment:3 by Jun Omae, 5 years ago

Release Notes: modified (diff)
Resolution: fixed
Status: assignedclosed

Thanks for the reviewing! Committed in [15263] and merged in [15264-15265].

Modify Ticket

Change Properties
Set your email in Preferences
as closed The owner will remain Jun Omae.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Jun Omae to the specified user.

Add Comment

E-mail address and name can be saved in the Preferences .
Note: See TracTickets for help on using tickets.