Checking permissions will fail unless trac.wiki.web_ui is imported

[Ryan J Ollos]

If trac.wiki.web_ui isn't imported, a statement such as self.assertTrue('WIKI_VIEW' in self.req.perm) will fail with traceback:

E..
======================================================================
ERROR: test_trac_1_0_permission_policies (__main__.TestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "./test_case.py", line 16, in test_trac_1_0_permission_policies
    self.assertTrue('WIKI_VIEW' in self.req.perm)
  File "/Users/rjollos/Documents/Workspace/trac-dev/teo-rjollos.git/trac/perm.py", line 586, in has_permission
    return self._has_permission(action, resource)
  File "/Users/rjollos/Documents/Workspace/trac-dev/teo-rjollos.git/trac/perm.py", line 600, in _has_permission
    check_permission(action, perm.username, resource, perm)
  File "/Users/rjollos/Documents/Workspace/trac-dev/teo-rjollos.git/trac/perm.py", line 495, in check_permission
    for policy in self.policies:
  File "/Users/rjollos/Documents/Workspace/trac-dev/teo-rjollos.git/trac/config.py", line 915, in __get__
    option=tag.code("[%s] %s" % (self.section, self.name))))
ConfigurationError: Cannot find implementation(s) of the <code>IPermissionPolicy</code> interface named <code>ReadonlyWikiPolicy</code>. Please check that the Component is enabled or update the option <code>[trac] permission_policies</code> in trac.ini.

----------------------------------------------------------------------
Ran 3 tests in 0.043s

FAILED (errors=1)

This might be confusing to developers. Maybe we should have the following in the EnvironmentStub initializer:

self.env.config.set('trac', 'permission_policies', 'DefaultPermissionPolicy, LegacyAttachmentPolicy')

or even:

self.env.config.set('trac', 'permission_policies', 'DefaultPermissionPolicy)

Or we could add an import to EnvironmentStub:

import trac.wiki.web_ui

test_case.py​ is a minimal test module that demonstrates the behavior.

[Ryan J Ollos]

Initially I observed the behavior in ​DiscussionPlugin, so added ​[th 16007/discussionplugin/1.2/tracdiscussion/tests/__init__.py]. However, the statement appears to no longer be necessary, probably due to a change in the modules that are imported resulting in a transitive import of trac.wiki.web_ui.

[Ryan J Ollos]

All tests pass with the following proposed change:

trac/test.py

@@ -380 +380 @@
         for name_or_class in disable or ():
             config_key = self._component_name(name_or_class)
             self.config.set('components', config_key, 'disabled')
+        self.config.set('trac', 'permission_policies',
+                        'DefaultPermissionPolicy, LegacyAttachmentPolicy')
 
         # -- logging
         from trac.log import logger_handler_factory

[Ryan J Ollos]

Committed to 1.2-stable in r15270, merged to trunk in r15271.