Edgewall Software
Modify

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#12397 closed defect (cantfix)

Stack trace lacks indenting

Reported by: Wolph <wolph@…> Owned by:
Priority: normal Milestone:
Component: rendering Version:
Severity: normal Keywords:
Cc: support@… Branch:
Release Notes:
API Changes:

Description (last modified by Jun Omae)

When Trac displays a stack trace (internal error) it allows you to click on the function name to show the code and variables. The code over there is unfortunately not visibly indented. There is indenting but it's not visible due to HTML hiding the spaces.

I've personally fixed it by putting <code> tags within the <td> on line 165 of error.html: source:/trunk/trac/templates/error.html@13103:165#L165

Attachments (2)

20160311T085216.png (24.6 KB ) - added by Jun Omae 3 years ago.
Screen Shot 2016-03-11 at 01.06.42.png (50.8 KB ) - added by Wolph <wolph@…> 3 years ago.
screenshot without indenting

Download all attachments as: .zip

Change History (12)

comment:1 by Wolph <wolph@…>, 3 years ago

Description: modified (diff)

by Jun Omae, 3 years ago

Attachment: 20160311T085216.png added

comment:2 by Wolph <wolph@…>, 3 years ago

That's curious, perhaps some css is overwriting it for me. Would you be able to show me the relevant css so I know what to grep for in my source?

comment:3 by Jun Omae, 3 years ago

It seems that works for me. There is the indentation. Please post the details, also, the diff format for your changes.

Last edited 3 years ago by Jun Omae (previous) (diff)

by Wolph <wolph@…>, 3 years ago

screenshot without indenting

comment:4 by Wolph <wolph@…>, 3 years ago

For me it looks roughly like this:

https://trac.edgewall.org/raw-attachment/ticket/12397/Screen%20Shot%202016-03-11%20at%2001.06.42.png

It could be related to the Agilo Scrum plugin I have installed. It adds a slightly custom style but the stack trace page looks mostly similar.

comment:5 by Jun Omae, 3 years ago

Cc: support@… added
Component: web frontendrendering
Resolution: cantfix
Status: newclosed

comment:6 by Jun Omae, 3 years ago

Description: modified (diff)

comment:7 by Wolph <wolph@…>, 3 years ago

I'll report the bug downstream :)

Sorry for the useless bug report guys. Although it would still help to know which css rules take care of the formatting in the regular case so I can find the proper fix.

comment:8 by Jun Omae, 3 years ago

You can use Inspector of Web Developer in Firefox, Developer Tools in Chrome, etc.

Also, that issue is cuased by that Agilo plugin prevents use of common/css/trac.css in Trac core.

comment:9 by Wolph <wolph@…>, 3 years ago

I'm aware of that part. I know how my css looks, the thing I don't know is how it's supposed to look since I don't have a regular trac install where I can generate an error.

comment:10 by stefano.rago@…, 3 years ago

@Jun thanks for the cc
@reporter we received your report on the google group here:
https://groups.google.com/forum/#!searchin/agilo/Agilo$20breaks$20stack$20trace$20indenting/agilo/VcIKrigfDGA/xoxrzOsOCQAJ

Thanks for your report, we will follow up there

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The ticket will remain with no owner.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.