MercurialConnector should log the import errors

[anonymous]

If the Browse Source main item​ is not shown because get_real_repositories()​ no errors are logged.

With the mercurial plugin it's hard to figure out why it's not working. Nowhere is it logged if the mercurial module can not be imported.

[Jun Omae]

TracMercurial should log the import errors, not IRepositoryConnector component.

[Jun Omae]

tracext/hg/backend.py

@@ -118 +118 @@
     has_phasestr = None
 
 except ImportError, e:
-    hg_import_error = e
+    hg_import_error = exception_to_unicode(e)
     ui = object
 
 
@@ -391 +391 @@
         locale_dir = pkg_resources.resource_filename(__name__, 'locale')
         add_domain(self.env.path, locale_dir)
         self._version = self._version_info = None
-        if not hg_import_error:
+        if hg_import_error:
+            self.log.warn('Failed to load Mercurial bindings (%s)',
+                          hg_import_error)
+        else:
             try:
                 from mercurial.version import get_version
                 self._version = get_version()

After the patch, the following warning would be logged.

11:00:43 PM Trac[backend] WARNING: Failed to load Mercurial bindings (ImportError: No module named mercurial)

[Jun Omae]

#11911 was closed as duplicate.

[Peter Suter]

Pushed changes from comment:2 in [59/mercurial-plugin].