Edgewall Software
Modify

Opened 7 years ago

Closed 5 years ago

#12111 closed enhancement (wontfix)

Replace Milestone.move_tickets with a static method of the Ticket class

Reported by: Ryan J Ollos Owned by:
Priority: normal Milestone:
Component: ticket system Version:
Severity: normal Keywords:
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

Milestone.move_tickets was added in #5658 for milestone:1.0.2. I've been bothered by this method since it was implemented. It doesn't seem to fit well in the Milestone class.

The method performs table scope queries on the ticket table. It seems more appropriate therefore to deprecate Milestone.move_tickets and replace it with a class method of the Ticket class, such as Ticket.set_milestone. We may want to consider what is an appropriate naming scheme for static class methods. So far, the only pattern I see is with the select method: tags/trac-1.0.2/trac/ticket/model.py#L1133.

Attachments (0)

Change History (2)

comment:1 by Ryan J Ollos, 7 years ago

Milestone: next-dev-1.1.xnext-dev-1.3.x

Narrowing focus for milestone:1.2. Please move ticket to milestone:1.2 if you intend to fix it.

comment:2 by Ryan J Ollos, 5 years ago

Milestone: next-dev-1.3.x
Resolution: wontfix
Status: newclosed

I might revisit when we do some refactoring, but it's not worth bothering with for now.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The ticket will remain with no owner.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none) to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.