Duplicate column name 'priority_value' is raised in custom query with MySQL

[Jun Omae]

When priority_value is defined as custom field and filter with the field, the following error is raised on MySQL with Trac 0.12-stable and 1.0-stable. No errors on SQLite and PostgreSQL.

2015-06-25 16:30:00,151 Trac[main] ERROR: Internal Server Error:
Traceback (most recent call last):
  File "/venv/trac/1.0.6.post2/lib/python2.5/site-packages/trac/web/main.py", line 534, in _dispatch_request
    dispatcher.dispatch(req)
  File "/venv/trac/1.0.6.post2/lib/python2.5/site-packages/trac/web/main.py", line 227, in dispatch
    resp = chosen_handler.process_request(req)
  File "/venv/trac/1.0.6.post2/lib/python2.5/site-packages/trac/ticket/query.py", line 984, in process_request
    return self.display_html(req, query)
  File "/venv/trac/1.0.6.post2/lib/python2.5/site-packages/trac/ticket/query.py", line 1082, in display_html
    tickets = query.execute(req)
  File "/venv/trac/1.0.6.post2/lib/python2.5/site-packages/trac/ticket/query.py", line 301, in execute
    self.num_items = self._count(sql, args)
  File "/venv/trac/1.0.6.post2/lib/python2.5/site-packages/trac/ticket/query.py", line 282, in _count
    % sql, args)[0][0]
  File "/venv/trac/1.0.6.post2/lib/python2.5/site-packages/trac/db/api.py", line 124, in execute
    return db.execute(query, params)
  File "/venv/trac/1.0.6.post2/lib/python2.5/site-packages/trac/db/util.py", line 128, in execute
    cursor.execute(query, params if params is not None else [])
  File "/venv/trac/1.0.6.post2/lib/python2.5/site-packages/trac/db/util.py", line 72, in execute
    return self.cursor.execute(sql_escape_percent(sql), args)
  File "/venv/py25/lib/python2.5/site-packages/MySQLdb/cursors.py", line 205, in execute
    self.errorhandler(self, exc, value)
  File "/venv/py25/lib/python2.5/site-packages/MySQLdb/connections.py", line 36, in defaulterrorhandler
    raise errorclass, errorvalue
OperationalError: (1060, "Duplicate column name 'priority_value'")

[Jun Omae]

Query in trac/ticket/query.py has no errors on SQLite and PostgreSQL however priority.value AS priority_value and priority_value custom field are conflicted.

We could use _priority_value instead of priority_value because name of custom field should match ^[a-zA-Z][a-zA-Z0-9_]+$. But these changes might be API changes for a user which customizes query_results.html.

trac/ticket/query.py

@@ -459 +459 @@
         sql = []
         sql.append("SELECT " + ",".join(['t.%s AS %s' % (c, c) for c in cols
                                          if c not in custom_fields]))
-        sql.append(",priority.value AS priority_value")
+        sql.append(",priority.value AS _priority_value")
 
         if use_joins:
             # Use LEFT OUTER JOIN for ticket_custom table

trac/ticket/templates/query_results.html

@@ -75 +75 @@
           <py:with vars="ticket_context = context.child('ticket', result.id)">
             <py:if test="'TICKET_VIEW' in perm(ticket_context.resource)">
 
-              <tr class="${'odd' if idx % 2 else 'even'} prio${result.priority_value}${
+              <tr class="${'odd' if idx % 2 else 'even'} prio${result._priority_value}${
                 ' added' if 'added' in result else ''}${
                 ' changed' if 'changed' in result else ''}${
                 ' removed' if 'removed' in result else ''}">

[Jun Omae]

Proposed changes in log:jomae.git@t12112.

[Ryan J Ollos]

Changes look good, and tests pass after rebasing with SQLite, PostgreSQL and MySQL.

[Jun Omae]

Thanks for the review. Committed in [14570].