High CPU usage and hangup in repository browser due to svn:externals

[Jun Omae]

High CPU usage and hangup occurs when a directory is viewed in repository browser after path -r42 //hostname is set to svn:externals property of the directory.

The leading double slash characters in non-absolute url leads the issue.

trac/versioncontrol/svn_prop.py

@@ -51 +51 @@
         elif name == 'svn:mergeinfo' or name.startswith('svnmerge-'):
             return self._render_mergeinfo(name, mode, context, props)
 
+    def _is_abs_url(self, url):
+        return url and '://' in url
+
     def _render_externals(self, prop):
         if not self._externals_map:
             for dummykey, value in self.config.options('svn:externals'):
@@ -77 +80 @@
                 rev = elements[1]
                 rev = rev.replace('-r', '')
             # retrieve a matching entry in the externals map
+            if not self._is_abs_url(url):
+                externals.append((external, None, None, None, None))
+                continue
             prefix = []
             base_url = url
             while base_url:

[Jun Omae]

Proposed changes in [b8d03d4f1/jomae.git], adding unit tests for rendering svn:externals property.

[Ryan J Ollos]

milestone:0.12.7 still hasn't been released, but I will try to take care of that by this weekend so that you can apply the change for milestone:0.12.8.

[Jun Omae]

[f9289ed48/jomae.git] for 1.0-stable.

[Ryan J Ollos]

I'll hold off generating 1.0.7 and 1.1.6 until this ticket is resolved.

[Jun Omae]

Committed in [14161], merged to 1.0-stable in [14162], and merged to trunk in [14163].